2021-02-18 11:30:52

by Greg Kroah-Hartman

Subject: Re: [PATCH] misc/pvpanic: Export module FDT device table

On Thu, Feb 18, 2021 at 05:40:24PM +0800, Shile Zhang wrote:
> Export the module FDT device table to ensure the FDT compatible strings
> are listed in the module alias. This help the pvpanic driver can be
> loaded on boot automatically not only the ACPI device, but also the FDT
> device.
>
> Signed-off-by: Shile Zhang <[email protected]>
> ---
> drivers/misc/pvpanic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
> index 41cab297d66e..2356d621967e 100644
> --- a/drivers/misc/pvpanic.c
> +++ b/drivers/misc/pvpanic.c
> @@ -92,6 +92,7 @@ static const struct of_device_id pvpanic_mmio_match[] = {
> { .compatible = "qemu,pvpanic-mmio", },
> {}
> };
> +MODULE_DEVICE_TABLE(of, pvpanic_mmio_match);

What caused this to not work properly? I.e. should there be a "Fixes:"
tag in the commit changelog as well?

thanks,

greg k-h

2021-02-18 12:22:20

by Shile Zhang

Subject: Re: [PATCH] misc/pvpanic: Export module FDT device table

On 2021/2/18 18:00, Greg Kroah-Hartman wrote:
> On Thu, Feb 18, 2021 at 05:40:24PM +0800, Shile Zhang wrote:
>> Export the module FDT device table to ensure the FDT compatible strings
>> are listed in the module alias. This help the pvpanic driver can be
>> loaded on boot automatically not only the ACPI device, but also the FDT
>> device.
>>
>> Signed-off-by: Shile Zhang <[email protected]>
>> ---
>> drivers/misc/pvpanic.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
>> index 41cab297d66e..2356d621967e 100644
>> --- a/drivers/misc/pvpanic.c
>> +++ b/drivers/misc/pvpanic.c
>> @@ -92,6 +92,7 @@ static const struct of_device_id pvpanic_mmio_match[] = {
>> { .compatible = "qemu,pvpanic-mmio", },
>> {}
>> };
>> +MODULE_DEVICE_TABLE(of, pvpanic_mmio_match);
>
> What caused this to not work properly? I.e. should there be a "Fixes:"
> tag in the commit changelog as well?

Sorry, I think it should be:

Fixes: 46f934c9a12fc ("misc/pvpanic: add support to get pvpanic device
info FDT")

Shall I sent v2 with this update?

Thanks!

>
> thanks,
>
> greg k-h
>

2021-02-18 14:29:31

by Greg Kroah-Hartman

Subject: Re: [PATCH] misc/pvpanic: Export module FDT device table

On Thu, Feb 18, 2021 at 06:51:08PM +0800, Shile Zhang wrote:
>
>
> On 2021/2/18 18:00, Greg Kroah-Hartman wrote:
> > On Thu, Feb 18, 2021 at 05:40:24PM +0800, Shile Zhang wrote:
> > > Export the module FDT device table to ensure the FDT compatible strings
> > > are listed in the module alias. This help the pvpanic driver can be
> > > loaded on boot automatically not only the ACPI device, but also the FDT
> > > device.
> > >
> > > Signed-off-by: Shile Zhang <[email protected]>
> > > ---
> > > drivers/misc/pvpanic.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
> > > index 41cab297d66e..2356d621967e 100644
> > > --- a/drivers/misc/pvpanic.c
> > > +++ b/drivers/misc/pvpanic.c
> > > @@ -92,6 +92,7 @@ static const struct of_device_id pvpanic_mmio_match[] = {
> > > { .compatible = "qemu,pvpanic-mmio", },
> > > {}
> > > };
> > > +MODULE_DEVICE_TABLE(of, pvpanic_mmio_match);
> >
> > What caused this to not work properly? I.e. should there be a "Fixes:"
> > tag in the commit changelog as well?
>
> Sorry, I think it should be:
>
> Fixes: 46f934c9a12fc ("misc/pvpanic: add support to get pvpanic device info
> FDT")
>
> Shall I sent v2 with this update?

Yes please.