Fix one occurrences of the checkpatch.pl error:
ERROR: "foo* bar" should be "foo *bar"
Signed-off-by: Xingwei He <[email protected]>
---
arch/m68k/sun3/idprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/m68k/sun3/idprom.c b/arch/m68k/sun3/idprom.c
index 1ace5353d78f..a4c5cd072c87 100644
--- a/arch/m68k/sun3/idprom.c
+++ b/arch/m68k/sun3/idprom.c
@@ -83,7 +83,7 @@ static void __init display_system_type(unsigned char
machtype)
prom_halt();
}
-void sun3_get_model(unsigned char* model)
+void sun3_get_model(unsigned char *model)
{
register int i;
On Thu, Jul 13, 2023 at 10:09 AM <[email protected]> wrote:
> Fix one occurrences of the checkpatch.pl error:
> ERROR: "foo* bar" should be "foo *bar"
>
> Signed-off-by: Xingwei He <[email protected]>
Thanks for your patch!
But obviously you forgot to run scripts/checkpatch.pl on your own patch:
WARNING: From:/Signed-off-by: email name mismatch: 'From:
[email protected]' != 'Signed-off-by: Xingwei He
<[email protected]>'
> --- a/arch/m68k/sun3/idprom.c
> +++ b/arch/m68k/sun3/idprom.c
> @@ -83,7 +83,7 @@ static void __init display_system_type(unsigned char
> machtype)
> prom_halt();
> }
>
> -void sun3_get_model(unsigned char* model)
> +void sun3_get_model(unsigned char *model)
> {
> register int i;
Whitespace-damaged, so it fails to apply.
These problems are present in all your patches, so something is\
wrong in your workflow. Please test your patches by running
scripts/checkpatch.pl, emailing them to yourself, and trying to
apply them.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds