2022-12-20 21:22:58

by Siddh Raman Pant

[permalink] [raw]
Subject: Re: [PATCH] selftests: Add missing <sys/syscall.h> to mount_setattr test

On Thu, Dec 01 2022 at 20:32:18 +0530, Daan De Meyer wrote:
> Including <sys/syscall.h> is required to define __NR_mount_setattr
> and __NR_open_tree which the mount_setattr test relies on.
>
> Signed-off-by: Daan De Meyer <[email protected]>
> ---
> tools/testing/selftests/mount_setattr/mount_setattr_test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/mount_setattr/mount_setattr_test.c b/tools/testing/selftests/mount_setattr/mount_setattr_test.c
> index 8c5fea68ae67..da85f8af482c 100644
> --- a/tools/testing/selftests/mount_setattr/mount_setattr_test.c
> +++ b/tools/testing/selftests/mount_setattr/mount_setattr_test.c
> @@ -11,6 +11,7 @@
> #include <sys/wait.h>
> #include <sys/vfs.h>
> #include <sys/statvfs.h>
> +#include <sys/syscall.h>
> #include <sys/sysinfo.h>
> #include <stdlib.h>
> #include <unistd.h>

Tested-by: Siddh Raman Pant <[email protected]>

Though this oversight actually led to gcc detecting another
another error [1], as it entered the #ifndef __NR_mount_setattr
block.

Thanks,
Siddh

[1] https://lore.kernel.org/all/[email protected]/