2020-08-20 02:20:28

by Tian Tao

Subject: [PATCH] uacce: Use kobj_to_dev() instead of container_of()

Use kobj_to_dev() instead of container_of()

Signed-off-by: Tian Tao <[email protected]>
Reviewed-by: Zhou Wang <[email protected]>
---
drivers/misc/uacce/uacce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
index a5b8dab..a9da7b1 100644
--- a/drivers/misc/uacce/uacce.c
+++ b/drivers/misc/uacce/uacce.c
@@ -370,7 +370,7 @@ static struct attribute *uacce_dev_attrs[] = {
static umode_t uacce_dev_is_visible(struct kobject *kobj,
struct attribute *attr, int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct uacce_device *uacce = to_uacce_device(dev);

if (((attr == &dev_attr_region_mmio_size.attr) &&
--
2.7.4

2020-08-20 02:54:17

by zhangfei

Subject: Re: [PATCH] uacce: Use kobj_to_dev() instead of container_of()

On 2020/8/20 上午10:16, Tian Tao wrote:
> Use kobj_to_dev() instead of container_of()
>
> Signed-off-by: Tian Tao <[email protected]>
> Reviewed-by: Zhou Wang <[email protected]>
Acked-by: Zhangfei Gao <[email protected]>

Thanks
> ---
> drivers/misc/uacce/uacce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
> index a5b8dab..a9da7b1 100644
> --- a/drivers/misc/uacce/uacce.c
> +++ b/drivers/misc/uacce/uacce.c
> @@ -370,7 +370,7 @@ static struct attribute *uacce_dev_attrs[] = {
> static umode_t uacce_dev_is_visible(struct kobject *kobj,
> struct attribute *attr, int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct uacce_device *uacce = to_uacce_device(dev);
>
> if (((attr == &dev_attr_region_mmio_size.attr) &&