2022-01-10 04:25:07

by Matthew Wilcox

Subject: [PATCH v2 19/28] gup: Convert try_grab_page() to call try_grab_folio()

try_grab_page() only cares about success or failure, not about the
type returned.

Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
---
mm/gup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/gup.c b/mm/gup.c
index 20703de2f107..c3e514172eaf 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -192,7 +192,7 @@ bool __must_check try_grab_page(struct page *page, unsigned int flags)
if (!(flags & (FOLL_GET | FOLL_PIN)))
return true;

- return try_grab_compound_head(page, 1, flags);
+ return try_grab_folio(page, 1, flags);
}

/**
--
2.33.0

2022-01-10 08:39:09

by Christoph Hellwig

Subject: Re: [PATCH v2 19/28] gup: Convert try_grab_page() to call try_grab_folio()

On Mon, Jan 10, 2022 at 04:23:57AM +0000, Matthew Wilcox (Oracle) wrote:
> try_grab_page() only cares about success or failure, not about the
> type returned.

Looks good,

Reviewed-by: Christoph Hellwig <[email protected]>

2022-01-11 07:01:21

by John Hubbard

Subject: Re: [PATCH v2 19/28] gup: Convert try_grab_page() to call try_grab_folio()

On 1/9/22 20:23, Matthew Wilcox (Oracle) wrote:
> try_grab_page() only cares about success or failure, not about the
> type returned.
>
> Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
> ---
> mm/gup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: John Hubbard <[email protected]>


thanks,
--
John Hubbard
NVIDIA

>
> diff --git a/mm/gup.c b/mm/gup.c
> index 20703de2f107..c3e514172eaf 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -192,7 +192,7 @@ bool __must_check try_grab_page(struct page *page, unsigned int flags)
> if (!(flags & (FOLL_GET | FOLL_PIN)))
> return true;
>
> - return try_grab_compound_head(page, 1, flags);
> + return try_grab_folio(page, 1, flags);
> }
>
> /**