From: YueHaibing <[email protected]>
Fix sparse warning:
drivers/gpu/drm/panfrost/panfrost_gem.c:17:6:
warning: symbol 'panfrost_gem_free_object' was not declared. Should it be static?
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
drivers/gpu/drm/panfrost/panfrost_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_gem.c b/drivers/gpu/drm/panfrost/panfrost_gem.c
index 8a03762..a5528a3 100644
--- a/drivers/gpu/drm/panfrost/panfrost_gem.c
+++ b/drivers/gpu/drm/panfrost/panfrost_gem.c
@@ -14,7 +14,7 @@
/* Called DRM core on the last userspace/kernel unreference of the
* BO.
*/
-void panfrost_gem_free_object(struct drm_gem_object *obj)
+static void panfrost_gem_free_object(struct drm_gem_object *obj)
{
struct panfrost_gem_object *bo = to_panfrost_bo(obj);
struct panfrost_device *pfdev = obj->dev->dev_private;
--
2.7.4
On 16/04/2019 16:00, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Fix sparse warning:
>
> drivers/gpu/drm/panfrost/panfrost_gem.c:17:6:
> warning: symbol 'panfrost_gem_free_object' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>
Reviewed-by: Steven Price <[email protected]>
Although while we're fixing sparse warnings, there's a few more in Panfrost:
-----8<-------
From 8aaf778262744cfbebb9b7f274ead9ba600526b0 Mon Sep 17 00:00:00 2001
From: Steven Price <[email protected]>
Date: Wed, 17 Apr 2019 15:47:49 +0100
Subject: [PATCH] drm/panfrost: Add missing include
Fix sparse warnings:
drivers/gpu/drm/panfrost/panfrost_devfreq.c:133:5:
warning: symbol 'panfrost_devfreq_init' was not declared. Should it be static?
drivers/gpu/drm/panfrost/panfrost_devfreq.c:168:6:
warning: symbol 'panfrost_devfreq_resume' was not declared. Should it be static?
drivers/gpu/drm/panfrost/panfrost_devfreq.c:182:6:
warning: symbol 'panfrost_devfreq_suspend' was not declared. Should it be static?
drivers/gpu/drm/panfrost/panfrost_devfreq.c:212:6:
warning: symbol 'panfrost_devfreq_record_transition' was not declared. Should it be static?
Signed-off-by: Steven Price <[email protected]>
---
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
index a8121ae67ee3..238bd1d89d43 100644
--- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
+++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
@@ -7,6 +7,7 @@
#include <linux/regulator/consumer.h>
#include "panfrost_device.h"
+#include "panfrost_devfreq.h"
#include "panfrost_features.h"
#include "panfrost_issues.h"
#include "panfrost_gpu.h"
--
2.20.1
Both patches are:
Reviewed-by: Tomeu Vizoso <[email protected]>
Thanks!
On 4/17/19 4:51 PM, Steven Price wrote:
> On 16/04/2019 16:00, Yue Haibing wrote:
>> From: YueHaibing <[email protected]>
>>
>> Fix sparse warning:
>>
>> drivers/gpu/drm/panfrost/panfrost_gem.c:17:6:
>> warning: symbol 'panfrost_gem_free_object' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <[email protected]>
>> Signed-off-by: YueHaibing <[email protected]>
>
> Reviewed-by: Steven Price <[email protected]>
>
> Although while we're fixing sparse warnings, there's a few more in Panfrost:
>
> -----8<-------
> From 8aaf778262744cfbebb9b7f274ead9ba600526b0 Mon Sep 17 00:00:00 2001
> From: Steven Price <[email protected]>
> Date: Wed, 17 Apr 2019 15:47:49 +0100
> Subject: [PATCH] drm/panfrost: Add missing include
>
> Fix sparse warnings:
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:133:5:
> warning: symbol 'panfrost_devfreq_init' was not declared. Should it be static?
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:168:6:
> warning: symbol 'panfrost_devfreq_resume' was not declared. Should it be static?
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:182:6:
> warning: symbol 'panfrost_devfreq_suspend' was not declared. Should it be static?
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:212:6:
> warning: symbol 'panfrost_devfreq_record_transition' was not declared. Should it be static?
>
> Signed-off-by: Steven Price <[email protected]>
> ---
> drivers/gpu/drm/panfrost/panfrost_devfreq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> index a8121ae67ee3..238bd1d89d43 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> @@ -7,6 +7,7 @@
> #include <linux/regulator/consumer.h>
>
> #include "panfrost_device.h"
> +#include "panfrost_devfreq.h"
> #include "panfrost_features.h"
> #include "panfrost_issues.h"
> #include "panfrost_gpu.h"
>
On Wed, Apr 17, 2019 at 9:51 AM Steven Price <[email protected]> wrote:
>
> On 16/04/2019 16:00, Yue Haibing wrote:
> > From: YueHaibing <[email protected]>
> >
> > Fix sparse warning:
> >
> > drivers/gpu/drm/panfrost/panfrost_gem.c:17:6:
> > warning: symbol 'panfrost_gem_free_object' was not declared. Should it be static?
> >
> > Reported-by: Hulk Robot <[email protected]>
> > Signed-off-by: YueHaibing <[email protected]>
>
> Reviewed-by: Steven Price <[email protected]>
>
> Although while we're fixing sparse warnings, there's a few more in Panfrost:
>
> -----8<-------
> From 8aaf778262744cfbebb9b7f274ead9ba600526b0 Mon Sep 17 00:00:00 2001
> From: Steven Price <[email protected]>
> Date: Wed, 17 Apr 2019 15:47:49 +0100
> Subject: [PATCH] drm/panfrost: Add missing include
>
> Fix sparse warnings:
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:133:5:
> warning: symbol 'panfrost_devfreq_init' was not declared. Should it be static?
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:168:6:
> warning: symbol 'panfrost_devfreq_resume' was not declared. Should it be static?
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:182:6:
> warning: symbol 'panfrost_devfreq_suspend' was not declared. Should it be static?
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:212:6:
> warning: symbol 'panfrost_devfreq_record_transition' was not declared. Should it be static?
>
> Signed-off-by: Steven Price <[email protected]>
> ---
> drivers/gpu/drm/panfrost/panfrost_devfreq.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
On Tue, Apr 16, 2019 at 10:01 AM Yue Haibing <[email protected]> wrote:
>
> From: YueHaibing <[email protected]>
>
> Fix sparse warning:
>
> drivers/gpu/drm/panfrost/panfrost_gem.c:17:6:
> warning: symbol 'panfrost_gem_free_object' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/gpu/drm/panfrost/panfrost_gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.