Hi Dmitry,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/input/touchscreen/wacom_w8001.c: In function 'w8001_setup':
drivers/input/touchscreen/wacom_w8001.c:287: error: implicit declaration of function 'mdelay'
Caused by commit b8fe15cb1b435928f9967d660e925fe7afb32787 ("Input:
wacom_w8001 - support pen or touch only devices"). See Rule 1 in
Documentation/SubmitChecklist.
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
On Wed, Dec 29, 2010 at 12:51:29PM +1100, Stephen Rothwell wrote:
> Hi Dmitry,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/input/touchscreen/wacom_w8001.c: In function 'w8001_setup':
> drivers/input/touchscreen/wacom_w8001.c:287: error: implicit declaration of function 'mdelay'
>
> Caused by commit b8fe15cb1b435928f9967d660e925fe7afb32787 ("Input:
> wacom_w8001 - support pen or touch only devices"). See Rule 1 in
> Documentation/SubmitChecklist.
>
> I have reverted that commit for today.
Thank you Stephen, I'll fix this up in my tree.
--
Dmitry
Hi Dmitry,
On Tue, 28 Dec 2010 18:34:58 -0800 Dmitry Torokhov <[email protected]> wrote:
>
> On Wed, Dec 29, 2010 at 12:51:29PM +1100, Stephen Rothwell wrote:
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/input/touchscreen/wacom_w8001.c: In function 'w8001_setup':
> > drivers/input/touchscreen/wacom_w8001.c:287: error: implicit declaration of function 'mdelay'
> >
> > Caused by commit b8fe15cb1b435928f9967d660e925fe7afb32787 ("Input:
> > wacom_w8001 - support pen or touch only devices"). See Rule 1 in
> > Documentation/SubmitChecklist.
> >
> > I have reverted that commit for today.
>
> Thank you Stephen, I'll fix this up in my tree.
I note that this commit has been redone in your tree (as commit
11a862ed9f04558e222fa15a5fbd76698fed11ff) but there have been no changes
to it at all (except the commit date).
I have reverted that commit from today's linux-next.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
On Wed, Dec 29, 2010 at 3:51 PM, Stephen Rothwell <[email protected]> wrote:
> Hi Dmitry,
>
> On Tue, 28 Dec 2010 18:34:58 -0800 Dmitry Torokhov <[email protected]> wrote:
>>
>> On Wed, Dec 29, 2010 at 12:51:29PM +1100, Stephen Rothwell wrote:
>> >
>> > After merging the final tree, today's linux-next build (powerpc
>> > allyesconfig) failed like this:
>> >
>> > drivers/input/touchscreen/wacom_w8001.c: In function 'w8001_setup':
>> > drivers/input/touchscreen/wacom_w8001.c:287: error: implicit declaration of function 'mdelay'
>> >
>> > Caused by commit b8fe15cb1b435928f9967d660e925fe7afb32787 ("Input:
>> > wacom_w8001 - support pen or touch only devices"). ?See Rule 1 in
>> > Documentation/SubmitChecklist.
I do not see the error on my testing systems somehow. Does adding the
following line resolve the issue?
#include < include/linux/delay.h>
Ping
>> > I have reverted that commit for today.
>>
>> Thank you Stephen, I'll fix this up in my tree.
>
> I note that this commit has been redone in your tree (as commit
> 11a862ed9f04558e222fa15a5fbd76698fed11ff) but there have been no changes
> to it at all (except the commit date).
>
> I have reverted that commit from today's linux-next.
> --
> Cheers,
> Stephen Rothwell ? ? ? ? ? ? ? ? ? [email protected]
> http://www.canb.auug.org.au/~sfr/
>
On Thu, Dec 30, 2010 at 19:06, Ping Cheng <[email protected]> wrote:
> On Wed, Dec 29, 2010 at 3:51 PM, Stephen Rothwell <[email protected]> wrote:
>> On Tue, 28 Dec 2010 18:34:58 -0800 Dmitry Torokhov <[email protected]> wrote:
>>> On Wed, Dec 29, 2010 at 12:51:29PM +1100, Stephen Rothwell wrote:
>>> > After merging the final tree, today's linux-next build (powerpc
>>> > allyesconfig) failed like this:
>>> >
>>> > drivers/input/touchscreen/wacom_w8001.c: In function 'w8001_setup':
>>> > drivers/input/touchscreen/wacom_w8001.c:287: error: implicit declaration of function 'mdelay'
>>> >
>>> > Caused by commit b8fe15cb1b435928f9967d660e925fe7afb32787 ("Input:
>>> > wacom_w8001 - support pen or touch only devices"). See Rule 1 in
>>> > Documentation/SubmitChecklist.
>
> I do not see the error on my testing systems somehow. Does adding the
> following line resolve the issue?
>
> #include < include/linux/delay.h>
"#include <linux/delay.h>", I assume?
>>> > I have reverted that commit for today.
>>>
>>> Thank you Stephen, I'll fix this up in my tree.
>>
>> I note that this commit has been redone in your tree (as commit
>> 11a862ed9f04558e222fa15a5fbd76698fed11ff) but there have been no changes
>> to it at all (except the commit date).
>>
>> I have reverted that commit from today's linux-next.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Thu, Dec 30, 2010 at 11:58 AM, Geert Uytterhoeven
<[email protected]> wrote:
> On Thu, Dec 30, 2010 at 19:06, Ping Cheng <[email protected]> wrote:
>> On Wed, Dec 29, 2010 at 3:51 PM, Stephen Rothwell <[email protected]> wrote:
>>> On Tue, 28 Dec 2010 18:34:58 -0800 Dmitry Torokhov <[email protected]> wrote:
>>>> On Wed, Dec 29, 2010 at 12:51:29PM +1100, Stephen Rothwell wrote:
>>>> > After merging the final tree, today's linux-next build (powerpc
>>>> > allyesconfig) failed like this:
>>>> >
>>>> > drivers/input/touchscreen/wacom_w8001.c: In function 'w8001_setup':
>>>> > drivers/input/touchscreen/wacom_w8001.c:287: error: implicit declaration of function 'mdelay'
>>>> >
>>>> > Caused by commit b8fe15cb1b435928f9967d660e925fe7afb32787 ("Input:
>>>> > wacom_w8001 - support pen or touch only devices"). ?See Rule 1 in
>>>> > Documentation/SubmitChecklist.
>>
>> I do not see the error on my testing systems somehow. Does adding the
>> following line resolve the issue?
>>
>> #include < include/linux/delay.h>
>
> "#include <linux/delay.h>", I assume?
You are right. Take it as a typo or copy/paste error ;).
Ping