Hi Islam Amer
I got report that "Ubuntu 10.04 + BIOS A11" was tested and the "Eject CD" key is working
as expected. Sorry, I couldn't find any Studio 1555 to test myself and cannot provide you
with more details.
Also, you may try acpi_osi="Windows 2009" kernel parameter and see if there is any difference.
Thanks..
--rez
Rezwanul Kabir
Dell Linux Development
512-725-0766
>-----Original Message-----
>From: Kabir, Rezwanul
>Sent: Tuesday, June 08, 2010 11:34 AM
>To: 'Islam Amer'
>Cc: [email protected]; [email protected];
>[email protected]; [email protected]
>Subject: RE: Dell Studio 1555 eject key does not work ( small
>patch to fix included )
>
>Hi Islam Amer
>
> I have asked feedback from the BIOS team and will update
>this thread as soon as I get it.
> Thanks..
> --rez
>
>
>
>Rezwanul Kabir
>Dell Linux Development
>512-725-0766
>
>
>>-----Original Message-----
>>From: Islam Amer [mailto:[email protected]]
>>Sent: Tuesday, June 08, 2010 5:58 AM
>>To: Kabir, Rezwanul
>>Cc: [email protected]; [email protected];
>>[email protected]; [email protected]
>>Subject: Re: Dell Studio 1555 eject key does not work ( small
>patch to
>>fix included )
>>
>>Dear Rezwanul,
>>
>>I have been using this fix for quite some time without any
>visible ill
>>effects on the other keys or the system in general.
>>Of course it would be necessary to get feedback from other dell users.
>>
>>Thanks.
>>
>>On Thu, Jun 3, 2010 at 11:16 PM, Islam Amer <[email protected]> wrote:
>>> Hello,
>>>
>>> I suspected the same about dell_new_hk_type, but I am confused that
>>> the rest of the fn keys work just fine out of the box. The
>>only button
>>> that didn't work was the eject key.
>>>
>>> Attached is the dmidecode output.
>>>
>>> Thanks
>>>
>>> On Thu, Jun 3, 2010 at 5:57 AM, ?<[email protected]> wrote:
>>>>
>>>>>Hi Rez,
>>>>>
>>>>>Any thoughts on this?
>>>>>
>>>>
>>>>
>>>> ?From the discussion below, it seems that this system does not
>>>> implement the new WMI scheme ( which is when
>>dell_new_hk_type=true is
>>>> set). So, at issue here is the legacy code. Without
>knowing exactly
>>>> why BIOS would behave differently in this particular case,
>>the fix seems arbitrary. Let me see if I can get hold of the BIOS
>>developer(if possible) and provide feedback in this thread.
>>>>
>>>> Islam Amer
>>>>
>>>> ? Can you attach dmidecode output from the system here?
>>>>
>>>> Thanks..
>>>> ? --rez
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>>On Thu, Jun 03, 2010 at 01:14:09AM +0400, Islam Amer wrote
>>>>>> Hello,
>>>>>>
>>>>>> Pressing the eject key on my Dell Studio 1555 does not work
>>>>>and dmesg
>>>>>> produces this message :
>>>>>> dell-wmi: Unknown key 0 pressed
>>>>>>
>>>>>> Adding a debugging printk in dell-wmi.c after line 222
>like this :
>>>>>>
>>>>>> printk(KERN_INFO "dell:wmi 0x%x , 0x%x \n", buffer_entry[1],
>>>>>> buffer_entry[2]);
>>>>>>
>>>>>> dmesg now shows :
>>>>>>
>>>>>> dell:wmi 0x0 , 0xe009
>>>>>> dell-wmi: Unknown key 0 pressed
>>>>>>
>>>>>> So for some reason buffer_entry[1] is used although it is empty.
>>>>>>
>>>>>> Falling back to buffer_entry[2] in case buffer_entry[1] is 0x0
>>>>>> makes the button work.
>>>>>>
>>>>>> I suspect it might be better to fix the "dell_new_hk_type" logic
>>>>>> though
>>>>>>
>>>>>> I had submitted this as
>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=16075 but
>>repeating the
>>>>>> information and patch here as per Andrew Morton's suggestion.
>>>>>>
>>>>>>
>>>>>> Thanks.
>>>>>>
>>>>>> ---
>>>>>linux-sidux-2.6-2.6.34/drivers/platform/x86/dell-wmi.c.orig
>>>>>2010-06-03
>>>>>> 01:02:17.418824168 +0400
>>>>>> +++ linux-sidux-2.6-2.6.34/drivers/platform/x86/dell-wmi.c
>>>>>2010-06-03
>>>>>> 01:01:40.641833249 +0400
>>>>>> @@ -221,7 +221,7 @@ static void dell_wmi_notify(u32 value, v
>>>>>> ? ? ? ? ? ? ? ? ? ? ?return;
>>>>>> ? ? ? ? ? ? ?}
>>>>>>
>>>>>> - ? ? ? ? ? ?if (dell_new_hk_type)
>>>>>> + ? ? ? ? ? ?if (dell_new_hk_type || buffer_entry[1] == 0x0)
>>>>>> ? ? ? ? ? ? ? ? ? ? ?reported_key = (int)buffer_entry[2];
>>>>>> ? ? ? ? ? ? ?else
>>>>>> ? ? ? ? ? ? ? ? ? ? ?reported_key = (int)buffer_entry[1]
>& 0xffff;
>>>>>>
>>>>>--
>>>>>Matthew Garrett | [email protected]
>>>>>
>>>
>>
>-
On Thu, Jun 10, 2010 at 01:36:56PM -0500, [email protected] wrote:
> Hi Islam Amer
>
> I got report that "Ubuntu 10.04 + BIOS A11" was tested and the "Eject CD" key is working
> as expected. Sorry, I couldn't find any Studio 1555 to test myself and cannot provide you
> with more details.
>
> Also, you may try acpi_osi="Windows 2009" kernel parameter and see if there is any difference.
That's the default on any kernel that has this support in dell-wmi. Rez,
could you let me know if the proposed patch breaks the spec in ways that
are likely to cause problems?
--
Matthew Garrett | [email protected]
Hello all,
My bios version is A08 , I see that A11 was recently released but the
changelog doesn't say much.
Which is better, upgrade and hope the problem goes away, or wait until
we have a fix that is agreed upon ?
Thanks.
On Thu, Jun 10, 2010 at 9:40 PM, Matthew Garrett <[email protected]> wrote:
> On Thu, Jun 10, 2010 at 01:36:56PM -0500, [email protected] wrote:
>> Hi Islam Amer
>>
>> ? ?I got report that "Ubuntu 10.04 + BIOS A11" was tested and the "Eject CD" key is working
>> ? ?as expected. Sorry, I couldn't find any Studio 1555 to test myself and cannot provide you
>> ? ?with more details.
>>
>> ? ? Also, you may try acpi_osi="Windows 2009" kernel parameter and see if there is any difference.
>
> That's the default on any kernel that has this support in dell-wmi. Rez,
> could you let me know if the proposed patch breaks the spec in ways that
> are likely to cause problems?
>
> --
> Matthew Garrett | [email protected]
>
Islam Amer
Please try the new BIOS A11 and eliminate any potential BIOS issues. The BIOS team confirmed that
they weren't able to reproduce the issue with Ubuntu 10.04 and A11.
Thanks..
--rez
Rezwanul Kabir
Dell Linux Development
512-725-0766
>-----Original Message-----
>From: Islam Amer [mailto:[email protected]]
>Sent: Thursday, June 10, 2010 6:52 PM
>To: Matthew Garrett
>Cc: Kabir, Rezwanul; [email protected];
>[email protected]; [email protected]
>Subject: Re: Dell Studio 1555 eject key does not work ( small
>patch to fix included )
>
>Hello all,
>
>My bios version is A08 , I see that A11 was recently released
>but the changelog doesn't say much.
>
>Which is better, upgrade and hope the problem goes away, or
>wait until we have a fix that is agreed upon ?
>
>Thanks.
>
>On Thu, Jun 10, 2010 at 9:40 PM, Matthew Garrett
><[email protected]> wrote:
>> On Thu, Jun 10, 2010 at 01:36:56PM -0500,
>[email protected] wrote:
>>> Hi Islam Amer
>>>
>>> ? ?I got report that "Ubuntu 10.04 + BIOS A11" was tested and the
>>> "Eject CD" key is working
>>> ? ?as expected. Sorry, I couldn't find any Studio 1555 to
>test myself
>>> and cannot provide you
>>> ? ?with more details.
>>>
>>> ? ? Also, you may try acpi_osi="Windows 2009" kernel
>parameter and see if there is any difference.
>>
>> That's the default on any kernel that has this support in dell-wmi.
>> Rez, could you let me know if the proposed patch breaks the spec in
>> ways that are likely to cause problems?
>>
>> --
>> Matthew Garrett | [email protected]
>>
>-
Rezwanul,
I've updated my bios to A11 and installed a new unmodified kernel. The
issue still persists that the eject key produces "dell-wmi: Unknown
key 0 pressed" in the dmesg output and it doesn't work.
It is possible that Ubuntu is including patches to fix stuff. The
latest patch for the Lucid kernel at
http://archive.ubuntu.com/ubuntu/pool/main/l/linux/linux_2.6.32-22.36.diff.gz
does include patches that touch wmi and dell-wmi code, but I can't
find a specific change that would fix this issue.
I might try to selectively apply patches from it and see if it gets fixed.
Thanks.
On Fri, Jun 11, 2010 at 3:15 AM, <[email protected]> wrote:
> Islam Amer
>
> ? Please try the new BIOS A11 and eliminate any potential BIOS issues. The BIOS team confirmed that
> ? they weren't able to reproduce the issue with Ubuntu 10.04 and A11.
>
> Thanks..
> ? --rez
>
>
>
>
> Rezwanul Kabir
> Dell Linux Development
> 512-725-0766
>
>
>>-----Original Message-----
>>From: Islam Amer [mailto:[email protected]]
>>Sent: Thursday, June 10, 2010 6:52 PM
>>To: Matthew Garrett
>>Cc: Kabir, Rezwanul; [email protected];
>>[email protected]; [email protected]
>>Subject: Re: Dell Studio 1555 eject key does not work ( small
>>patch to fix included )
>>
>>Hello all,
>>
>>My bios version is A08 , I see that A11 was recently released
>>but the changelog doesn't say much.
>>
>>Which is better, upgrade and hope the problem goes away, or
>>wait until we have a fix that is agreed upon ?
>>
>>Thanks.
>>
>>On Thu, Jun 10, 2010 at 9:40 PM, Matthew Garrett
>><[email protected]> wrote:
>>> On Thu, Jun 10, 2010 at 01:36:56PM -0500,
>>[email protected] wrote:
>>>> Hi Islam Amer
>>>>
>>>> ? ?I got report that "Ubuntu 10.04 + BIOS A11" was tested and the
>>>> "Eject CD" key is working
>>>> ? ?as expected. Sorry, I couldn't find any Studio 1555 to
>>test myself
>>>> and cannot provide you
>>>> ? ?with more details.
>>>>
>>>> ? ? Also, you may try acpi_osi="Windows 2009" kernel
>>parameter and see if there is any difference.
>>>
>>> That's the default on any kernel that has this support in dell-wmi.
>>> Rez, could you let me know if the proposed patch breaks the spec in
>>> ways that are likely to cause problems?
>>>
>>> --
>>> Matthew Garrett | [email protected]
>>>
>>
Islam Amer,
You could try a vanilla stable kernel from
http://kernel.ubuntu.com/~kernel-ppa/mainline/v2.6.32.15.5-lucid/ to see
if we've borked the dell-wmi code.
rtg
On 06/11/2010 07:28 AM, Islam Amer wrote:
> Rezwanul,
>
> I've updated my bios to A11 and installed a new unmodified kernel. The
> issue still persists that the eject key produces "dell-wmi: Unknown
> key 0 pressed" in the dmesg output and it doesn't work.
>
> It is possible that Ubuntu is including patches to fix stuff. The
> latest patch for the Lucid kernel at
> http://archive.ubuntu.com/ubuntu/pool/main/l/linux/linux_2.6.32-22.36.diff.gz
> does include patches that touch wmi and dell-wmi code, but I can't
> find a specific change that would fix this issue.
>
> I might try to selectively apply patches from it and see if it gets fixed.
>
> Thanks.
>
>
> On Fri, Jun 11, 2010 at 3:15 AM,<[email protected]> wrote:
>> Islam Amer
>>
>> Please try the new BIOS A11 and eliminate any potential BIOS issues. The BIOS team confirmed that
>> they weren't able to reproduce the issue with Ubuntu 10.04 and A11.
>>
>> Thanks..
>> --rez
>>
>>
>>
>>
>> Rezwanul Kabir
>> Dell Linux Development
>> 512-725-0766
>>
>>
>>> -----Original Message-----
>>> From: Islam Amer [mailto:[email protected]]
>>> Sent: Thursday, June 10, 2010 6:52 PM
>>> To: Matthew Garrett
>>> Cc: Kabir, Rezwanul; [email protected];
>>> [email protected]; [email protected]
>>> Subject: Re: Dell Studio 1555 eject key does not work ( small
>>> patch to fix included )
>>>
>>> Hello all,
>>>
>>> My bios version is A08 , I see that A11 was recently released
>>> but the changelog doesn't say much.
>>>
>>> Which is better, upgrade and hope the problem goes away, or
>>> wait until we have a fix that is agreed upon ?
>>>
>>> Thanks.
>>>
>>> On Thu, Jun 10, 2010 at 9:40 PM, Matthew Garrett
>>> <[email protected]> wrote:
>>>> On Thu, Jun 10, 2010 at 01:36:56PM -0500,
>>> [email protected] wrote:
>>>>> Hi Islam Amer
>>>>>
>>>>> I got report that "Ubuntu 10.04 + BIOS A11" was tested and the
>>>>> "Eject CD" key is working
>>>>> as expected. Sorry, I couldn't find any Studio 1555 to
>>> test myself
>>>>> and cannot provide you
>>>>> with more details.
>>>>>
>>>>> Also, you may try acpi_osi="Windows 2009" kernel
>>> parameter and see if there is any difference.
>>>>
>>>> That's the default on any kernel that has this support in dell-wmi.
>>>> Rez, could you let me know if the proposed patch breaks the spec in
>>>> ways that are likely to cause problems?
>>>>
>>>> --
>>>> Matthew Garrett | [email protected]
>>>>
>>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Tim Gardner [email protected]
Tim I am running debian,
I think it's the other way round, the mainline kernel is borked (
regarding dell-wmi and eject key ) while the lucid patched kernel
works ( as reported by dell team ).
I guess I could download a Lucid livecd and see if the eject key works
there ( event only as it won't eject the lived while it is running :)
)
On Fri, Jun 11, 2010 at 5:08 PM, Tim Gardner <[email protected]> wrote:
> Islam Amer,
>
> You could try a vanilla stable kernel from
> http://kernel.ubuntu.com/~kernel-ppa/mainline/v2.6.32.15.5-lucid/ to see if
> we've borked the dell-wmi code.
>
> rtg
>
> On 06/11/2010 07:28 AM, Islam Amer wrote:
>>
>> Rezwanul,
>>
>> I've updated my bios to A11 and installed a new unmodified kernel. The
>> issue still persists that the eject key produces "dell-wmi: Unknown
>> key 0 pressed" in the dmesg output and it doesn't work.
>>
>> It is possible that Ubuntu is including patches to fix stuff. The
>> latest patch for the Lucid kernel at
>>
>> http://archive.ubuntu.com/ubuntu/pool/main/l/linux/linux_2.6.32-22.36.diff.gz
>> does include patches that touch wmi and dell-wmi code, but I can't
>> find a specific change that would fix this issue.
>>
>> I might try to selectively apply patches from it and see if it gets fixed.
>>
>> Thanks.
>>
>>
>> On Fri, Jun 11, 2010 at 3:15 AM,<[email protected]> ?wrote:
>>>
>>> Islam Amer
>>>
>>> ? Please try the new BIOS A11 and eliminate any potential BIOS issues.
>>> The BIOS team confirmed that
>>> ? they weren't able to reproduce the issue with Ubuntu 10.04 and A11.
>>>
>>> Thanks..
>>> ? --rez
>>>
>>>
>>>
>>>
>>> Rezwanul Kabir
>>> Dell Linux Development
>>> 512-725-0766
>>>
>>>
>>>> -----Original Message-----
>>>> From: Islam Amer [mailto:[email protected]]
>>>> Sent: Thursday, June 10, 2010 6:52 PM
>>>> To: Matthew Garrett
>>>> Cc: Kabir, Rezwanul; [email protected];
>>>> [email protected]; [email protected]
>>>> Subject: Re: Dell Studio 1555 eject key does not work ( small
>>>> patch to fix included )
>>>>
>>>> Hello all,
>>>>
>>>> My bios version is A08 , I see that A11 was recently released
>>>> but the changelog doesn't say much.
>>>>
>>>> Which is better, upgrade and hope the problem goes away, or
>>>> wait until we have a fix that is agreed upon ?
>>>>
>>>> Thanks.
>>>>
>>>> On Thu, Jun 10, 2010 at 9:40 PM, Matthew Garrett
>>>> <[email protected]> ?wrote:
>>>>>
>>>>> On Thu, Jun 10, 2010 at 01:36:56PM -0500,
>>>>
>>>> [email protected] wrote:
>>>>>>
>>>>>> Hi Islam Amer
>>>>>>
>>>>>> ? ?I got report that "Ubuntu 10.04 + BIOS A11" was tested and the
>>>>>> "Eject CD" key is working
>>>>>> ? ?as expected. Sorry, I couldn't find any Studio 1555 to
>>>>
>>>> test myself
>>>>>>
>>>>>> and cannot provide you
>>>>>> ? ?with more details.
>>>>>>
>>>>>> ? ? Also, you may try acpi_osi="Windows 2009" kernel
>>>>
>>>> parameter and see if there is any difference.
>>>>>
>>>>> That's the default on any kernel that has this support in dell-wmi.
>>>>> Rez, could you let me know if the proposed patch breaks the spec in
>>>>> ways that are likely to cause problems?
>>>>>
>>>>> --
>>>>> Matthew Garrett | [email protected]
>>>>>
>>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to [email protected]
>> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at ?http://www.tux.org/lkml/
>
>
> --
> Tim Gardner [email protected]
>
Dear Tim,
I tried the mainline kernel 2.6.32-0206321505-generic as you suggested
and the eject key doesn't work but it also doesn't produce the error
message in dmesg.
I then tried the 2.6.32-22.36-generic from
http://packages.ubuntu.com/lucid/linux-image-2.6.32-22-generic and I
found the eject key working fine.
So there is something in the ubuntu patchset that fixes this issue.
On Fri, Jun 11, 2010 at 5:23 PM, Islam Amer <[email protected]> wrote:
> Tim I am running debian,
>
> I think it's the other way round, the mainline kernel is borked (
> regarding dell-wmi and eject key ) while the lucid patched kernel
> works ( as reported by dell team ).
>
> I guess I could download a Lucid livecd and see if the eject key works
> there ( event only as it won't eject the lived while it is running :)
> )
>
> On Fri, Jun 11, 2010 at 5:08 PM, Tim Gardner <[email protected]> wrote:
>> Islam Amer,
>>
>> You could try a vanilla stable kernel from
>> http://kernel.ubuntu.com/~kernel-ppa/mainline/v2.6.32.15.5-lucid/ to see if
>> we've borked the dell-wmi code.
>>
>> rtg
>>
>> On 06/11/2010 07:28 AM, Islam Amer wrote:
>>>
>>> Rezwanul,
>>>
>>> I've updated my bios to A11 and installed a new unmodified kernel. The
>>> issue still persists that the eject key produces "dell-wmi: Unknown
>>> key 0 pressed" in the dmesg output and it doesn't work.
>>>
>>> It is possible that Ubuntu is including patches to fix stuff. The
>>> latest patch for the Lucid kernel at
>>>
>>> http://archive.ubuntu.com/ubuntu/pool/main/l/linux/linux_2.6.32-22.36.diff.gz
>>> does include patches that touch wmi and dell-wmi code, but I can't
>>> find a specific change that would fix this issue.
>>>
>>> I might try to selectively apply patches from it and see if it gets fixed.
>>>
>>> Thanks.
>>>
>>>
>>> On Fri, Jun 11, 2010 at 3:15 AM,<[email protected]> ?wrote:
>>>>
>>>> Islam Amer
>>>>
>>>> ? Please try the new BIOS A11 and eliminate any potential BIOS issues.
>>>> The BIOS team confirmed that
>>>> ? they weren't able to reproduce the issue with Ubuntu 10.04 and A11.
>>>>
>>>> Thanks..
>>>> ? --rez
>>>>
>>>>
>>>>
>>>>
>>>> Rezwanul Kabir
>>>> Dell Linux Development
>>>> 512-725-0766
>>>>
>>>>
>>>>> -----Original Message-----
>>>>> From: Islam Amer [mailto:[email protected]]
>>>>> Sent: Thursday, June 10, 2010 6:52 PM
>>>>> To: Matthew Garrett
>>>>> Cc: Kabir, Rezwanul; [email protected];
>>>>> [email protected]; [email protected]
>>>>> Subject: Re: Dell Studio 1555 eject key does not work ( small
>>>>> patch to fix included )
>>>>>
>>>>> Hello all,
>>>>>
>>>>> My bios version is A08 , I see that A11 was recently released
>>>>> but the changelog doesn't say much.
>>>>>
>>>>> Which is better, upgrade and hope the problem goes away, or
>>>>> wait until we have a fix that is agreed upon ?
>>>>>
>>>>> Thanks.
>>>>>
>>>>> On Thu, Jun 10, 2010 at 9:40 PM, Matthew Garrett
>>>>> <[email protected]> ?wrote:
>>>>>>
>>>>>> On Thu, Jun 10, 2010 at 01:36:56PM -0500,
>>>>>
>>>>> [email protected] wrote:
>>>>>>>
>>>>>>> Hi Islam Amer
>>>>>>>
>>>>>>> ? ?I got report that "Ubuntu 10.04 + BIOS A11" was tested and the
>>>>>>> "Eject CD" key is working
>>>>>>> ? ?as expected. Sorry, I couldn't find any Studio 1555 to
>>>>>
>>>>> test myself
>>>>>>>
>>>>>>> and cannot provide you
>>>>>>> ? ?with more details.
>>>>>>>
>>>>>>> ? ? Also, you may try acpi_osi="Windows 2009" kernel
>>>>>
>>>>> parameter and see if there is any difference.
>>>>>>
>>>>>> That's the default on any kernel that has this support in dell-wmi.
>>>>>> Rez, could you let me know if the proposed patch breaks the spec in
>>>>>> ways that are likely to cause problems?
>>>>>>
>>>>>> --
>>>>>> Matthew Garrett | [email protected]
>>>>>>
>>>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>>> the body of a message to [email protected]
>>> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>>> Please read the FAQ at ?http://www.tux.org/lkml/
>>
>>
>> --
>> Tim Gardner [email protected]
>>
>
The only difference between 2.6.32.15 and Ubuntu Lucid wrt dell-wmi.c is
this:
43,46d42
< /* Temporary workaround until the WMI sysfs interface goes in.
< Borrowed from acer-wmi */
< MODULE_ALIAS("dmi:*:*Dell*:*:");
<
I wonder about input event filtering? There are substantial differences
in drivers/input/input.c.
rtg
On 06/11/2010 12:02 PM, Islam Amer wrote:
> Dear Tim,
>
> I tried the mainline kernel 2.6.32-0206321505-generic as you suggested
> and the eject key doesn't work but it also doesn't produce the error
> message in dmesg.
>
> I then tried the 2.6.32-22.36-generic from
> http://packages.ubuntu.com/lucid/linux-image-2.6.32-22-generic and I
> found the eject key working fine.
>
> So there is something in the ubuntu patchset that fixes this issue.
>
> On Fri, Jun 11, 2010 at 5:23 PM, Islam Amer<[email protected]> wrote:
>> Tim I am running debian,
>>
>> I think it's the other way round, the mainline kernel is borked (
>> regarding dell-wmi and eject key ) while the lucid patched kernel
>> works ( as reported by dell team ).
>>
>> I guess I could download a Lucid livecd and see if the eject key works
>> there ( event only as it won't eject the lived while it is running :)
>> )
>>
>> On Fri, Jun 11, 2010 at 5:08 PM, Tim Gardner<[email protected]> wrote:
>>> Islam Amer,
>>>
>>> You could try a vanilla stable kernel from
>>> http://kernel.ubuntu.com/~kernel-ppa/mainline/v2.6.32.15.5-lucid/ to see if
>>> we've borked the dell-wmi code.
>>>
>>> rtg
>>>
>>> On 06/11/2010 07:28 AM, Islam Amer wrote:
>>>>
>>>> Rezwanul,
>>>>
>>>> I've updated my bios to A11 and installed a new unmodified kernel. The
>>>> issue still persists that the eject key produces "dell-wmi: Unknown
>>>> key 0 pressed" in the dmesg output and it doesn't work.
>>>>
>>>> It is possible that Ubuntu is including patches to fix stuff. The
>>>> latest patch for the Lucid kernel at
>>>>
>>>> http://archive.ubuntu.com/ubuntu/pool/main/l/linux/linux_2.6.32-22.36.diff.gz
>>>> does include patches that touch wmi and dell-wmi code, but I can't
>>>> find a specific change that would fix this issue.
>>>>
>>>> I might try to selectively apply patches from it and see if it gets fixed.
>>>>
>>>> Thanks.
>>>>
>>>>
>>>> On Fri, Jun 11, 2010 at 3:15 AM,<[email protected]> wrote:
>>>>>
>>>>> Islam Amer
>>>>>
>>>>> Please try the new BIOS A11 and eliminate any potential BIOS issues.
>>>>> The BIOS team confirmed that
>>>>> they weren't able to reproduce the issue with Ubuntu 10.04 and A11.
>>>>>
>>>>> Thanks..
>>>>> --rez
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> Rezwanul Kabir
>>>>> Dell Linux Development
>>>>> 512-725-0766
>>>>>
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Islam Amer [mailto:[email protected]]
>>>>>> Sent: Thursday, June 10, 2010 6:52 PM
>>>>>> To: Matthew Garrett
>>>>>> Cc: Kabir, Rezwanul; [email protected];
>>>>>> [email protected]; [email protected]
>>>>>> Subject: Re: Dell Studio 1555 eject key does not work ( small
>>>>>> patch to fix included )
>>>>>>
>>>>>> Hello all,
>>>>>>
>>>>>> My bios version is A08 , I see that A11 was recently released
>>>>>> but the changelog doesn't say much.
>>>>>>
>>>>>> Which is better, upgrade and hope the problem goes away, or
>>>>>> wait until we have a fix that is agreed upon ?
>>>>>>
>>>>>> Thanks.
>>>>>>
>>>>>> On Thu, Jun 10, 2010 at 9:40 PM, Matthew Garrett
>>>>>> <[email protected]> wrote:
>>>>>>>
>>>>>>> On Thu, Jun 10, 2010 at 01:36:56PM -0500,
>>>>>>
>>>>>> [email protected] wrote:
>>>>>>>>
>>>>>>>> Hi Islam Amer
>>>>>>>>
>>>>>>>> I got report that "Ubuntu 10.04 + BIOS A11" was tested and the
>>>>>>>> "Eject CD" key is working
>>>>>>>> as expected. Sorry, I couldn't find any Studio 1555 to
>>>>>>
>>>>>> test myself
>>>>>>>>
>>>>>>>> and cannot provide you
>>>>>>>> with more details.
>>>>>>>>
>>>>>>>> Also, you may try acpi_osi="Windows 2009" kernel
>>>>>>
>>>>>> parameter and see if there is any difference.
>>>>>>>
>>>>>>> That's the default on any kernel that has this support in dell-wmi.
>>>>>>> Rez, could you let me know if the proposed patch breaks the spec in
>>>>>>> ways that are likely to cause problems?
>>>>>>>
>>>>>>> --
>>>>>>> Matthew Garrett | [email protected]
>>>>>>>
>>>>>>
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>>>> the body of a message to [email protected]
>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>> Please read the FAQ at http://www.tux.org/lkml/
>>>
>>>
>>> --
>>> Tim Gardner [email protected]
>>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Tim Gardner [email protected]
What would you like me to do now? I want to help :)
Thanks.
On Fri, Jun 11, 2010 at 9:35 PM, Tim Gardner <[email protected]> wrote:
> The only difference between 2.6.32.15 and Ubuntu Lucid wrt dell-wmi.c is
> this:
>
> 43,46d42
> < /* Temporary workaround until the WMI sysfs interface goes in.
> < ? ?Borrowed from acer-wmi */
> < MODULE_ALIAS("dmi:*:*Dell*:*:");
> <
>
> I wonder about input event filtering? There are substantial differences in
> drivers/input/input.c.
>
> rtg
>
> On 06/11/2010 12:02 PM, Islam Amer wrote:
>>
>> Dear Tim,
>>
>> I tried the mainline kernel 2.6.32-0206321505-generic as you suggested
>> and the eject key doesn't work but it also doesn't produce the error
>> message in dmesg.
>>
>> I then tried the 2.6.32-22.36-generic from
>> http://packages.ubuntu.com/lucid/linux-image-2.6.32-22-generic and I
>> found the eject key working fine.
>>
>> So there is something in the ubuntu patchset that fixes this issue.
>>
>> On Fri, Jun 11, 2010 at 5:23 PM, Islam Amer<[email protected]> ?wrote:
>>>
>>> Tim I am running debian,
>>>
>>> I think it's the other way round, the mainline kernel is borked (
>>> regarding dell-wmi and eject key ) while the lucid patched kernel
>>> works ( as reported by dell team ).
>>>
>>> I guess I could download a Lucid livecd and see if the eject key works
>>> there ( event only as it won't eject the lived while it is running :)
>>> )
>>>
>>> On Fri, Jun 11, 2010 at 5:08 PM, Tim Gardner<[email protected]>
>>> ?wrote:
>>>>
>>>> Islam Amer,
>>>>
>>>> You could try a vanilla stable kernel from
>>>> http://kernel.ubuntu.com/~kernel-ppa/mainline/v2.6.32.15.5-lucid/ to see
>>>> if
>>>> we've borked the dell-wmi code.
>>>>
>>>> rtg
>>>>
>>>> On 06/11/2010 07:28 AM, Islam Amer wrote:
>>>>>
>>>>> Rezwanul,
>>>>>
>>>>> I've updated my bios to A11 and installed a new unmodified kernel. The
>>>>> issue still persists that the eject key produces "dell-wmi: Unknown
>>>>> key 0 pressed" in the dmesg output and it doesn't work.
>>>>>
>>>>> It is possible that Ubuntu is including patches to fix stuff. The
>>>>> latest patch for the Lucid kernel at
>>>>>
>>>>>
>>>>> http://archive.ubuntu.com/ubuntu/pool/main/l/linux/linux_2.6.32-22.36.diff.gz
>>>>> does include patches that touch wmi and dell-wmi code, but I can't
>>>>> find a specific change that would fix this issue.
>>>>>
>>>>> I might try to selectively apply patches from it and see if it gets
>>>>> fixed.
>>>>>
>>>>> Thanks.
>>>>>
>>>>>
>>>>> On Fri, Jun 11, 2010 at 3:15 AM,<[email protected]> ? ?wrote:
>>>>>>
>>>>>> Islam Amer
>>>>>>
>>>>>> ? Please try the new BIOS A11 and eliminate any potential BIOS issues.
>>>>>> The BIOS team confirmed that
>>>>>> ? they weren't able to reproduce the issue with Ubuntu 10.04 and A11.
>>>>>>
>>>>>> Thanks..
>>>>>> ? --rez
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> Rezwanul Kabir
>>>>>> Dell Linux Development
>>>>>> 512-725-0766
>>>>>>
>>>>>>
>>>>>>> -----Original Message-----
>>>>>>> From: Islam Amer [mailto:[email protected]]
>>>>>>> Sent: Thursday, June 10, 2010 6:52 PM
>>>>>>> To: Matthew Garrett
>>>>>>> Cc: Kabir, Rezwanul; [email protected];
>>>>>>> [email protected]; [email protected]
>>>>>>> Subject: Re: Dell Studio 1555 eject key does not work ( small
>>>>>>> patch to fix included )
>>>>>>>
>>>>>>> Hello all,
>>>>>>>
>>>>>>> My bios version is A08 , I see that A11 was recently released
>>>>>>> but the changelog doesn't say much.
>>>>>>>
>>>>>>> Which is better, upgrade and hope the problem goes away, or
>>>>>>> wait until we have a fix that is agreed upon ?
>>>>>>>
>>>>>>> Thanks.
>>>>>>>
>>>>>>> On Thu, Jun 10, 2010 at 9:40 PM, Matthew Garrett
>>>>>>> <[email protected]> ? ?wrote:
>>>>>>>>
>>>>>>>> On Thu, Jun 10, 2010 at 01:36:56PM -0500,
>>>>>>>
>>>>>>> [email protected] wrote:
>>>>>>>>>
>>>>>>>>> Hi Islam Amer
>>>>>>>>>
>>>>>>>>> ? ?I got report that "Ubuntu 10.04 + BIOS A11" was tested and the
>>>>>>>>> "Eject CD" key is working
>>>>>>>>> ? ?as expected. Sorry, I couldn't find any Studio 1555 to
>>>>>>>
>>>>>>> test myself
>>>>>>>>>
>>>>>>>>> and cannot provide you
>>>>>>>>> ? ?with more details.
>>>>>>>>>
>>>>>>>>> ? ? Also, you may try acpi_osi="Windows 2009" kernel
>>>>>>>
>>>>>>> parameter and see if there is any difference.
>>>>>>>>
>>>>>>>> That's the default on any kernel that has this support in dell-wmi.
>>>>>>>> Rez, could you let me know if the proposed patch breaks the spec in
>>>>>>>> ways that are likely to cause problems?
>>>>>>>>
>>>>>>>> --
>>>>>>>> Matthew Garrett | [email protected]
>>>>>>>>
>>>>>>>
>>>>> --
>>>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel"
>>>>> in
>>>>> the body of a message to [email protected]
>>>>> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>>>>> Please read the FAQ at ?http://www.tux.org/lkml/
>>>>
>>>>
>>>> --
>>>> Tim Gardner [email protected]
>>>>
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to [email protected]
>> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at ?http://www.tux.org/lkml/
>
>
> --
> Tim Gardner [email protected]
>
Hi Matthew/Islam
I don't know how Ubuntu 10.04 fixed the issue, but from my communications with the BIOS team, I think
Islam's patch would be acceptable. "buffer_entry[1] == 0x0" would indicate HotKey events on these platforms.
Thanks..
--rez
Rezwanul Kabir
Dell Linux Development
512-725-0766
>-----Original Message-----
>From: Islam Amer [mailto:[email protected]]
>Sent: Friday, June 11, 2010 8:27 PM
>To: [email protected]
>Cc: Kabir, Rezwanul; [email protected];
>[email protected];
>[email protected]; [email protected]
>Subject: Re: Dell Studio 1555 eject key does not work ( small
>patch to fix included )
>
>What would you like me to do now? I want to help :)
>
>Thanks.
>
>On Fri, Jun 11, 2010 at 9:35 PM, Tim Gardner
><[email protected]> wrote:
>> The only difference between 2.6.32.15 and Ubuntu Lucid wrt
>dell-wmi.c
>> is
>> this:
>>
>> 43,46d42
>> < /* Temporary workaround until the WMI sysfs interface goes in.
>> < ? ?Borrowed from acer-wmi */
>> < MODULE_ALIAS("dmi:*:*Dell*:*:");
>> <
>>
>> I wonder about input event filtering? There are substantial
>> differences in drivers/input/input.c.
>>
>> rtg
>>
>> On 06/11/2010 12:02 PM, Islam Amer wrote:
>>>
>>> Dear Tim,
>>>
>>> I tried the mainline kernel 2.6.32-0206321505-generic as you
>>> suggested and the eject key doesn't work but it also
>doesn't produce
>>> the error message in dmesg.
>>>
>>> I then tried the 2.6.32-22.36-generic from
>>>
>http://packages.ubuntu.com/lucid/linux-image-2.6.32-22-generic and I
>>> found the eject key working fine.
>>>
>>> So there is something in the ubuntu patchset that fixes this issue.
>>>
>>> On Fri, Jun 11, 2010 at 5:23 PM, Islam
>Amer<[email protected]> ?wrote:
>>>>
>>>> Tim I am running debian,
>>>>
>>>> I think it's the other way round, the mainline kernel is borked (
>>>> regarding dell-wmi and eject key ) while the lucid patched kernel
>>>> works ( as reported by dell team ).
>>>>
>>>> I guess I could download a Lucid livecd and see if the eject key
>>>> works there ( event only as it won't eject the lived while it is
>>>> running :)
>>>> )
>>>>
>>>> On Fri, Jun 11, 2010 at 5:08 PM, Tim
>>>> Gardner<[email protected]>
>>>> ?wrote:
>>>>>
>>>>> Islam Amer,
>>>>>
>>>>> You could try a vanilla stable kernel from
>>>>> http://kernel.ubuntu.com/~kernel-ppa/mainline/v2.6.32.15.5-lucid/
>>>>> to see if we've borked the dell-wmi code.
>>>>>
>>>>> rtg
>>>>>
>>>>> On 06/11/2010 07:28 AM, Islam Amer wrote:
>>>>>>
>>>>>> Rezwanul,
>>>>>>
>>>>>> I've updated my bios to A11 and installed a new
>unmodified kernel.
>>>>>> The issue still persists that the eject key produces "dell-wmi:
>>>>>> Unknown key 0 pressed" in the dmesg output and it doesn't work.
>>>>>>
>>>>>> It is possible that Ubuntu is including patches to fix
>stuff. The
>>>>>> latest patch for the Lucid kernel at
>>>>>>
>>>>>>
>>>>>>
>http://archive.ubuntu.com/ubuntu/pool/main/l/linux/linux_2.6.32-22
>>>>>> .36.diff.gz does include patches that touch wmi and
>dell-wmi code,
>>>>>> but I can't find a specific change that would fix this issue.
>>>>>>
>>>>>> I might try to selectively apply patches from it and see if it
>>>>>> gets fixed.
>>>>>>
>>>>>> Thanks.
>>>>>>
>>>>>>
>>>>>> On Fri, Jun 11, 2010 at 3:15
>AM,<[email protected]> ? ?wrote:
>>>>>>>
>>>>>>> Islam Amer
>>>>>>>
>>>>>>> ? Please try the new BIOS A11 and eliminate any
>potential BIOS issues.
>>>>>>> The BIOS team confirmed that
>>>>>>> ? they weren't able to reproduce the issue with Ubuntu
>10.04 and A11.
>>>>>>>
>>>>>>> Thanks..
>>>>>>> ? --rez
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Rezwanul Kabir
>>>>>>> Dell Linux Development
>>>>>>> 512-725-0766
>>>>>>>
>>>>>>>
>>>>>>>> -----Original Message-----
>>>>>>>> From: Islam Amer [mailto:[email protected]]
>>>>>>>> Sent: Thursday, June 10, 2010 6:52 PM
>>>>>>>> To: Matthew Garrett
>>>>>>>> Cc: Kabir, Rezwanul; [email protected];
>>>>>>>> [email protected]; [email protected]
>>>>>>>> Subject: Re: Dell Studio 1555 eject key does not work ( small
>>>>>>>> patch to fix included )
>>>>>>>>
>>>>>>>> Hello all,
>>>>>>>>
>>>>>>>> My bios version is A08 , I see that A11 was recently released
>>>>>>>> but the changelog doesn't say much.
>>>>>>>>
>>>>>>>> Which is better, upgrade and hope the problem goes
>away, or wait
>>>>>>>> until we have a fix that is agreed upon ?
>>>>>>>>
>>>>>>>> Thanks.
>>>>>>>>
>>>>>>>> On Thu, Jun 10, 2010 at 9:40 PM, Matthew Garrett
>>>>>>>> <[email protected]> ? ?wrote:
>>>>>>>>>
>>>>>>>>> On Thu, Jun 10, 2010 at 01:36:56PM -0500,
>>>>>>>>
>>>>>>>> [email protected] wrote:
>>>>>>>>>>
>>>>>>>>>> Hi Islam Amer
>>>>>>>>>>
>>>>>>>>>> ? ?I got report that "Ubuntu 10.04 + BIOS A11" was
>tested and
>>>>>>>>>> the "Eject CD" key is working
>>>>>>>>>> ? ?as expected. Sorry, I couldn't find any Studio 1555 to
>>>>>>>>
>>>>>>>> test myself
>>>>>>>>>>
>>>>>>>>>> and cannot provide you
>>>>>>>>>> ? ?with more details.
>>>>>>>>>>
>>>>>>>>>> ? ? Also, you may try acpi_osi="Windows 2009" kernel
>>>>>>>>
>>>>>>>> parameter and see if there is any difference.
>>>>>>>>>
>>>>>>>>> That's the default on any kernel that has this
>support in dell-wmi.
>>>>>>>>> Rez, could you let me know if the proposed patch breaks the
>>>>>>>>> spec in ways that are likely to cause problems?
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Matthew Garrett | [email protected]
>>>>>>>>>
>>>>>>>>
>>>>>> --
>>>>>> To unsubscribe from this list: send the line
>"unsubscribe linux-kernel"
>>>>>> in
>>>>>> the body of a message to [email protected] More
>majordomo
>>>>>> info at ?http://vger.kernel.org/majordomo-info.html
>>>>>> Please read the FAQ at ?http://www.tux.org/lkml/
>>>>>
>>>>>
>>>>> --
>>>>> Tim Gardner [email protected]
>>>>>
>>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe
>>> linux-kernel" in the body of a message to [email protected]
>>> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>>> Please read the FAQ at ?http://www.tux.org/lkml/
>>
>>
>> --
>> Tim Gardner [email protected]
>>
>-
Ok, thanks, I'll queue that up.
--
Matthew Garrett | [email protected]