2019-12-05 16:17:09

by Chuhong Yuan

Subject: [PATCH] RDMA/cma: add missed unregister_pernet_subsys in init failure

The driver forgets to call unregister_pernet_subsys() in the error path
of cma_init().
Add the missed call to fix it.

Signed-off-by: Chuhong Yuan <[email protected]>
---
drivers/infiniband/core/cma.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index 25f2b70fd8ef..43a6f07e0afe 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -4763,6 +4763,7 @@ static int __init cma_init(void)
err:
unregister_netdevice_notifier(&cma_nb);
ib_sa_unregister_client(&sa_client);
+ unregister_pernet_subsys(&cma_pernet_operations);
err_wq:
destroy_workqueue(cma_wq);
return ret;
--
2.24.0

2019-12-05 19:10:01

by Parav Pandit

Subject: RE: [PATCH] RDMA/cma: add missed unregister_pernet_subsys in init failure

> From: [email protected] <linux-kernel-
> [email protected]> On Behalf Of Chuhong Yuan
> Sent: Thursday, December 5, 2019 10:07 AM
> The driver forgets to call unregister_pernet_subsys() in the error path of
> cma_init().
> Add the missed call to fix it.
>
> Signed-off-by: Chuhong Yuan <[email protected]>
> ---
> drivers/infiniband/core/cma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
> index 25f2b70fd8ef..43a6f07e0afe 100644
> --- a/drivers/infiniband/core/cma.c
> +++ b/drivers/infiniband/core/cma.c
> @@ -4763,6 +4763,7 @@ static int __init cma_init(void)
> err:
> unregister_netdevice_notifier(&cma_nb);
> ib_sa_unregister_client(&sa_client);
> + unregister_pernet_subsys(&cma_pernet_operations);
> err_wq:
> destroy_workqueue(cma_wq);
> return ret;
> --
> 2.24.0
Please add to commit log.

Fixes: 4be74b42a6d0 ("IB/cma: Separate port allocation to network namespaces ")

Reviewed-by: Parav Pandit <[email protected]>