> -----Original Message-----
> From: Kun Yi [mailto:[email protected]]
> Sent: Thursday, November 30, 2017 12:51 AM
> To: Oleksandr Shamray <[email protected]>
> Cc: [email protected]; [email protected]; system-sw-low-level
> <[email protected]>; [email protected];
> [email protected]; Vadim Pasternak <[email protected]>; linux-
> [email protected]; OpenBMC Maillist <[email protected]>; linux-
> [email protected]; [email protected];
> [email protected]; Jiri Pirko <[email protected]>; [email protected]; linux-
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: Re: [patch v12 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx
> families JTAG master driver
>
> Thanks for working on the driver, Oleksandr. I gave this a try on a board with
> Aspeed 2520. One question below:
>
> On Tue, Nov 14, 2017 at 8:11 AM, Oleksandr Shamray
> <[email protected]> wrote:
> > Driver adds support of Aspeed 2500/2400 series SOC JTAG master controller.
> >
> > Driver implements the following jtag ops:
> > - freq_get;
> > - freq_set;
> > - status_get;
> > - idle;
> > - xfer;
> >
[..]
> > +
> > +static const struct jtag_ops aspeed_jtag_ops = {
> > + .freq_get = aspeed_jtag_freq_get,
> > + .freq_set = aspeed_jtag_freq_set,
> > + .status_get = aspeed_jtag_status_get,
> > + .idle = aspeed_jtag_idle,
> > + .xfer = aspeed_jtag_xfer,
> > + .mode_set = aspeed_jtag_mode_set };
> > +
> > +static int aspeed_jtag_probe(struct platform_device *pdev) {
> > + struct aspeed_jtag *aspeed_jtag;
> > + struct jtag *jtag;
> > + int err;
> > +
> > + if (!of_device_is_compatible(pdev->dev.of_node,
> > + "aspeed,aspeed-jtag"))
>
> Should this be "aspeed,ast2400-jtag"/"aspeed,ast2500-jtag" as specified in the
> compatible string below?
>
Yes
> > + return -ENOMEM;
> > +
> > + jtag = jtag_alloc(sizeof(*aspeed_jtag), &aspeed_jtag_ops);
> > + if (!jtag)
> > + return -ENODEV;
> > +
> > + platform_set_drvdata(pdev, jtag);
> > + aspeed_jtag = jtag_priv(jtag);
> > + aspeed_jtag->dev = &pdev->dev;
> > +
[..]
> > +
> > +MODULE_AUTHOR("Oleksandr Shamray <[email protected]>");
> > +MODULE_DESCRIPTION("ASPEED JTAG driver"); MODULE_LICENSE("GPL
> v2");
> > --
> > 1.7.1
> >
> --
> Regards,
> Kun
Thanks.
BR
Oleksandr Shamray