2020-11-03 11:57:52

by Zou Wei

Subject: [PATCH -next] dpaa_eth: use false and true for bool variables

Fix coccicheck warnings:

./dpaa_eth.c:2549:2-22: WARNING: Assignment of 0/1 to bool variable
./dpaa_eth.c:2562:2-22: WARNING: Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index d9c2859..31407c1 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -2546,7 +2546,7 @@ static void dpaa_eth_napi_enable(struct dpaa_priv *priv)
for_each_online_cpu(i) {
percpu_priv = per_cpu_ptr(priv->percpu_priv, i);

- percpu_priv->np.down = 0;
+ percpu_priv->np.down = false;
napi_enable(&percpu_priv->np.napi);
}
}
@@ -2559,7 +2559,7 @@ static void dpaa_eth_napi_disable(struct dpaa_priv *priv)
for_each_online_cpu(i) {
percpu_priv = per_cpu_ptr(priv->percpu_priv, i);

- percpu_priv->np.down = 1;
+ percpu_priv->np.down = true;
napi_disable(&percpu_priv->np.napi);
}
}
--
2.6.2

2020-11-03 12:15:47

by Madalin-cristian Bucur

Subject: RE: [PATCH -next] dpaa_eth: use false and true for bool variables

> -----Original Message-----
> From: Zou Wei <[email protected]>
> Sent: 03 November 2020 14:05
> To: Madalin Bucur <[email protected]>; [email protected];
> [email protected]
> Cc: [email protected]; [email protected]; Zou Wei
> <[email protected]>
> Subject: [PATCH -next] dpaa_eth: use false and true for bool variables
>
> Fix coccicheck warnings:
>
> ./dpaa_eth.c:2549:2-22: WARNING: Assignment of 0/1 to bool variable
> ./dpaa_eth.c:2562:2-22: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index d9c2859..31407c1 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -2546,7 +2546,7 @@ static void dpaa_eth_napi_enable(struct dpaa_priv
> *priv)
> for_each_online_cpu(i) {
> percpu_priv = per_cpu_ptr(priv->percpu_priv, i);
>
> - percpu_priv->np.down = 0;
> + percpu_priv->np.down = false;
> napi_enable(&percpu_priv->np.napi);
> }
> }
> @@ -2559,7 +2559,7 @@ static void dpaa_eth_napi_disable(struct dpaa_priv
> *priv)
> for_each_online_cpu(i) {
> percpu_priv = per_cpu_ptr(priv->percpu_priv, i);
>
> - percpu_priv->np.down = 1;
> + percpu_priv->np.down = true;
> napi_disable(&percpu_priv->np.napi);
> }
> }
> --
> 2.6.2

Acked-by: Madalin Bucur <[email protected]>

2020-11-05 04:35:57

by Jakub Kicinski

Subject: Re: [PATCH -next] dpaa_eth: use false and true for bool variables

On Tue, 3 Nov 2020 12:13:29 +0000 Madalin Bucur wrote:
> > Fix coccicheck warnings:
> >
> > ./dpaa_eth.c:2549:2-22: WARNING: Assignment of 0/1 to bool variable
> > ./dpaa_eth.c:2562:2-22: WARNING: Assignment of 0/1 to bool variable
> >
> > Reported-by: Hulk Robot <[email protected]>
> > Signed-off-by: Zou Wei <[email protected]>
>
> Acked-by: Madalin Bucur <[email protected]>

Applied, thanks!