2020-05-07 13:11:03

by Gustavo A. R. Silva

Subject: [PATCH] PM / devfreq: imx: Fix inconsistent IS_ERR and PTR_ERR

Fix inconsistent IS_ERR and PTR_ERR in imx_bus_init_icc().

The proper pointer to be passed as argument to PTR_ERR() is
priv->icc_pdev.

This bug was detected with the help of Coccinelle.

Fixes: 16c1d2f1b0bd ("PM / devfreq: imx: Register interconnect device")
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/devfreq/imx-bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c
index 532e7954032f..4f38455ad742 100644
--- a/drivers/devfreq/imx-bus.c
+++ b/drivers/devfreq/imx-bus.c
@@ -88,8 +88,8 @@ static int imx_bus_init_icc(struct device *dev)
dev, icc_driver_name, -1, NULL, 0);
if (IS_ERR(priv->icc_pdev)) {
dev_err(dev, "failed to register icc provider %s: %ld\n",
- icc_driver_name, PTR_ERR(priv->devfreq));
- return PTR_ERR(priv->devfreq);
+ icc_driver_name, PTR_ERR(priv->icc_pdev));
+ return PTR_ERR(priv->icc_pdev);
}

return 0;
--
2.26.2

2020-05-07 13:32:24

by Aisheng Dong

Subject: RE: [PATCH] PM / devfreq: imx: Fix inconsistent IS_ERR and PTR_ERR

> From: Gustavo A. R. Silva <[email protected]>
> Sent: Thursday, May 7, 2020 9:13 PM
>
> Fix inconsistent IS_ERR and PTR_ERR in imx_bus_init_icc().
>
> The proper pointer to be passed as argument to PTR_ERR() is
> priv->icc_pdev.
>
> This bug was detected with the help of Coccinelle.
>
> Fixes: 16c1d2f1b0bd ("PM / devfreq: imx: Register interconnect device")
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Thanks for the fix.
Reviewed-by: Dong Aisheng <[email protected]>

Regards
Aisheng

> ---
> drivers/devfreq/imx-bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c index
> 532e7954032f..4f38455ad742 100644
> --- a/drivers/devfreq/imx-bus.c
> +++ b/drivers/devfreq/imx-bus.c
> @@ -88,8 +88,8 @@ static int imx_bus_init_icc(struct device *dev)
> dev, icc_driver_name, -1, NULL, 0);
> if (IS_ERR(priv->icc_pdev)) {
> dev_err(dev, "failed to register icc provider %s: %ld\n",
> - icc_driver_name, PTR_ERR(priv->devfreq));
> - return PTR_ERR(priv->devfreq);
> + icc_driver_name, PTR_ERR(priv->icc_pdev));
> + return PTR_ERR(priv->icc_pdev);
> }
>
> return 0;
> --
> 2.26.2

2020-05-08 03:47:57

by Chanwoo Choi

Subject: Re: [PATCH] PM / devfreq: imx: Fix inconsistent IS_ERR and PTR_ERR

On 5/7/20 10:12 PM, Gustavo A. R. Silva wrote:
> Fix inconsistent IS_ERR and PTR_ERR in imx_bus_init_icc().
>
> The proper pointer to be passed as argument to PTR_ERR() is
> priv->icc_pdev.
>
> This bug was detected with the help of Coccinelle.
>
> Fixes: 16c1d2f1b0bd ("PM / devfreq: imx: Register interconnect device")
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/devfreq/imx-bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c
> index 532e7954032f..4f38455ad742 100644
> --- a/drivers/devfreq/imx-bus.c
> +++ b/drivers/devfreq/imx-bus.c
> @@ -88,8 +88,8 @@ static int imx_bus_init_icc(struct device *dev)
> dev, icc_driver_name, -1, NULL, 0);
> if (IS_ERR(priv->icc_pdev)) {
> dev_err(dev, "failed to register icc provider %s: %ld\n",
> - icc_driver_name, PTR_ERR(priv->devfreq));
> - return PTR_ERR(priv->devfreq);
> + icc_driver_name, PTR_ERR(priv->icc_pdev));
> + return PTR_ERR(priv->icc_pdev);
> }
>
> return 0;
>

Applied it. Thanks.

--
Best Regards,
Chanwoo Choi
Samsung Electronics

2020-05-08 03:51:46

by Chanwoo Choi

Subject: Re: [PATCH] PM / devfreq: imx: Fix inconsistent IS_ERR and PTR_ERR

On 5/8/20 12:55 PM, Chanwoo Choi wrote:
> On 5/7/20 10:12 PM, Gustavo A. R. Silva wrote:
>> Fix inconsistent IS_ERR and PTR_ERR in imx_bus_init_icc().
>>
>> The proper pointer to be passed as argument to PTR_ERR() is
>> priv->icc_pdev.
>>
>> This bug was detected with the help of Coccinelle.
>>
>> Fixes: 16c1d2f1b0bd ("PM / devfreq: imx: Register interconnect device")
>> Signed-off-by: Gustavo A. R. Silva <[email protected]>
>> ---
>> drivers/devfreq/imx-bus.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c
>> index 532e7954032f..4f38455ad742 100644
>> --- a/drivers/devfreq/imx-bus.c
>> +++ b/drivers/devfreq/imx-bus.c
>> @@ -88,8 +88,8 @@ static int imx_bus_init_icc(struct device *dev)
>> dev, icc_driver_name, -1, NULL, 0);
>> if (IS_ERR(priv->icc_pdev)) {
>> dev_err(dev, "failed to register icc provider %s: %ld\n",
>> - icc_driver_name, PTR_ERR(priv->devfreq));
>> - return PTR_ERR(priv->devfreq);
>> + icc_driver_name, PTR_ERR(priv->icc_pdev));
>> + return PTR_ERR(priv->icc_pdev);
>> }
>>
>> return 0;
>>
>
> Applied it. Thanks.
>

I edit the patch title as following:
- before : PM / devfreq: imx: Fix inconsistent IS_ERR and PTR_ERR
- after : PM / devfreq: imx-bus: Fix inconsistent IS_ERR and PTR_ERR

Thanks.

--
Best Regards,
Chanwoo Choi
Samsung Electronics