On 24/12/2013 03:36, Wenyou Yang :
> Reviwed-by: Mark Brown <[email protected]>
> Signed-off-by: Wenyou Yang <[email protected]>
Wenyou,
While collecting patches for our next at91-3.16-dt branch I noticed this
patch that should go on top of the SAMA5D3 CMP board.
I would prefer to create another .dtsi file for CMP board and not mix
with the current cpu module usual board that does not contain this
regulator. But well we can do something even more simpler and move this
PMIC example to the newer SAMA5D3 Xplained board.
So, will it be possible for you to re-send a new patch targeted to
SAMA5D3 Xplained?
Thanks, bye.
> ---
> arch/arm/boot/dts/sama5d3xcm.dtsi | 46 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sama5d3xcm.dtsi b/arch/arm/boot/dts/sama5d3xcm.dtsi
> index 726a0f3..3d4e5c2 100644
> --- a/arch/arm/boot/dts/sama5d3xcm.dtsi
> +++ b/arch/arm/boot/dts/sama5d3xcm.dtsi
> @@ -38,6 +38,52 @@
> macb0: ethernet@f0028000 {
> phy-mode = "rgmii";
> };
> +
> + i2c1: i2c@f0018000 {
> + pmic: act8865@5b {
> + compatible = "active-semi,act8865";
> + reg = <0x5b>;
> + status = "disabled";
> +
> + regulators {
> + vcc_1v8_reg: DCDC_REG1 {
> + regulator-name = "VCC_1V8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> +
> + vcc_1v2_reg: DCDC_REG2 {
> + regulator-name = "VCC_1V2";
> + regulator-min-microvolt = <1100000>;
> + regulator-max-microvolt = <1300000>;
> + regulator-suspend-mem-microvolt = <1150000>;
> + regulator-suspend-standby-microvolt = <1150000>;
> + regulator-always-on;
> + };
> +
> + vcc_3v3_reg: DCDC_REG3 {
> + regulator-name = "VCC_3V3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
> + vddana_reg: LDO_REG1 {
> + regulator-name = "VDDANA";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
> + vddfuse_reg: LDO_REG2 {
> + regulator-name = "FUSE_2V5";
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <2500000>;
> + };
> + };
> + };
> + };
> };
>
> nand0: nand@60000000 {
>
--
Nicolas Ferre
Hi Nicolas,
> -----Original Message-----
> From: Ferre, Nicolas
> Sent: Saturday, April 19, 2014 5:26 AM
> To: Yang, Wenyou
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]
> Subject: Re: [PATCH v5 3/3] ARM: dts: sama5d3xcm: add the regulator
> device node
>
> On 24/12/2013 03:36, Wenyou Yang :
> > Reviwed-by: Mark Brown <[email protected]>
> > Signed-off-by: Wenyou Yang <[email protected]>
>
> Wenyou,
>
> While collecting patches for our next at91-3.16-dt branch I noticed
> this patch that should go on top of the SAMA5D3 CMP board.
>
> I would prefer to create another .dtsi file for CMP board and not mix
> with the current cpu module usual board that does not contain this
> regulator. But well we can do something even more simpler and move this
> PMIC example to the newer SAMA5D3 Xplained board.
>
> So, will it be possible for you to re-send a new patch targeted to
> SAMA5D3 Xplained?
OK, I will re-send a new patch.
>
> Thanks, bye.
>
>
> > ---
> > arch/arm/boot/dts/sama5d3xcm.dtsi | 46
> +++++++++++++++++++++++++++++++++++++
> > 1 file changed, 46 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sama5d3xcm.dtsi
> > b/arch/arm/boot/dts/sama5d3xcm.dtsi
> > index 726a0f3..3d4e5c2 100644
> > --- a/arch/arm/boot/dts/sama5d3xcm.dtsi
> > +++ b/arch/arm/boot/dts/sama5d3xcm.dtsi
> > @@ -38,6 +38,52 @@
> > macb0: ethernet@f0028000 {
> > phy-mode = "rgmii";
> > };
> > +
> > + i2c1: i2c@f0018000 {
> > + pmic: act8865@5b {
> > + compatible = "active-semi,act8865";
> > + reg = <0x5b>;
> > + status = "disabled";
> > +
> > + regulators {
> > + vcc_1v8_reg: DCDC_REG1 {
> > + regulator-name = "VCC_1V8";
> > + regulator-min-microvolt =
> <1800000>;
> > + regulator-max-microvolt =
> <1800000>;
> > + regulator-always-on;
> > + };
> > +
> > + vcc_1v2_reg: DCDC_REG2 {
> > + regulator-name = "VCC_1V2";
> > + regulator-min-microvolt =
> <1100000>;
> > + regulator-max-microvolt =
> <1300000>;
> > + regulator-suspend-mem-
> microvolt = <1150000>;
> > + regulator-suspend-standby-
> microvolt = <1150000>;
> > + regulator-always-on;
> > + };
> > +
> > + vcc_3v3_reg: DCDC_REG3 {
> > + regulator-name = "VCC_3V3";
> > + regulator-min-microvolt =
> <3300000>;
> > + regulator-max-microvolt =
> <3300000>;
> > + regulator-always-on;
> > + };
> > +
> > + vddana_reg: LDO_REG1 {
> > + regulator-name = "VDDANA";
> > + regulator-min-microvolt =
> <3300000>;
> > + regulator-max-microvolt =
> <3300000>;
> > + regulator-always-on;
> > + };
> > +
> > + vddfuse_reg: LDO_REG2 {
> > + regulator-name = "FUSE_2V5";
> > + regulator-min-microvolt =
> <2500000>;
> > + regulator-max-microvolt =
> <2500000>;
> > + };
> > + };
> > + };
> > + };
> > };
> >
> > nand0: nand@60000000 {
> >
>
>
> --
> Nicolas Ferre
Best Regards,
Wenyou Yang