by Philip, Avinash

[permalink] [raw]

Subject: RE: [PATCH 5/8] pwm: pwm-tiehrpwm: Add device-tree binding support for EHRPWM driver

On Tue, Nov 06, 2012 at 12:16:13, Bedia, Vaibhav wrote:
> On Mon, Nov 05, 2012 at 14:42:26, Philip, Avinash wrote:
> [...]
>
> > +#include <linux/of_device.h>
> > +#include <linux/pinctrl/consumer.h>
>
> Pinctrl changes should be separate patch. Morevoer, you don't mention
> that you making this change.

Ok. I will make a separate patch for pinctrl changes.

>
> > +
> > +#include "tipwmss.h"
> >
> > /* EHRPWM registers and bits definitions */
> >
> > @@ -107,6 +111,10 @@
> > #define AQCSFRC_CSFA_FRCHIGH BIT(1)
> > #define AQCSFRC_CSFA_DISSWFRC (BIT(1) | BIT(0))
> >
> > +#define EPWMCLK_EN_SHIFT 8
> > +
> > +#define PWM_CELL_SIZE 3
> > +
> > #define NUM_PWM_CHANNEL 2 /* EHRPWM channels */
> >
> > struct ehrpwm_pwm_chip {
> > @@ -392,12 +400,27 @@ static const struct pwm_ops ehrpwm_pwm_ops = {
> > .owner = THIS_MODULE,
> > };
> >
> > +#ifdef CONFIG_OF
> > +static const struct of_device_id ehrpwm_of_match[] = {
> > + {
> > + .compatible = "ti,am33xx-ehrpwm",
> > + },
> > + {},
> > +};
> > +MODULE_DEVICE_TABLE(of, ehrpwm_of_match);
> > +#endif
> > +
> > static int __devinit ehrpwm_pwm_probe(struct platform_device *pdev)
> > {
> > int ret;
> > struct resource *r;
> > struct clk *clk;
> > struct ehrpwm_pwm_chip *pc;
> > + struct pinctrl *pinctrl;
> > +
> > + pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
>
> I didn't see a patch adding the pinctrl entries.

Patch 8/8 has pinctrl entries in DT. First driver changes for supporting
DT data.

>
> > + if (IS_ERR(pinctrl))
> > + dev_warn(&pdev->dev, "failed to configure pins from driver\n");
> >
> > pc = devm_kzalloc(&pdev->dev, sizeof(*pc), GFP_KERNEL);
> > if (!pc) {
> > @@ -419,6 +442,7 @@ static int __devinit ehrpwm_pwm_probe(struct platform_device *pdev)
> >
> > pc->chip.dev = &pdev->dev;
> > pc->chip.ops = &ehrpwm_pwm_ops;
> > + pc->chip.of_pwm_n_cells = PWM_CELL_SIZE;
> > pc->chip.base = -1;
> > pc->chip.npwm = NUM_PWM_CHANNEL;
> >
> > @@ -437,8 +461,11 @@ static int __devinit ehrpwm_pwm_probe(struct platform_device *pdev)
> > dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret);
> > return ret;
> > }
> > -
> > pm_runtime_enable(&pdev->dev);
> > + pm_runtime_get_sync(&pdev->dev);
> > + pwmss_submodule_state_change(pdev->dev.parent, EPWMCLK_EN_SHIFT, true);
>
> I think you should modify this API to return the status for drivers to check.

Check for status check will add.

>
> Another related question, why should this clock be enabled in probe and not only when it
> is required?

This is another clock gating from PWM subsystem as all sub modules shared the clock resource.
Still this gating from PWM subsystem is required to access PWM sub modules.
Handling of this for context loss & restore done at pwmss driver, will add the support.

> Shouldn't it be disabled in suspend?

Will take care when adding suspend/resume functionality.

Thanks
Avinash

>
> Regards,
> Vaibhav
>

2012-11-07 15:22:01

by Philip, Avinash

[permalink] [raw]

Subject: RE: [PATCH 6/8] pwm: pwm-tiehrpwm: Adding TBCLK gating support.

On Tue, Nov 06, 2012 at 12:16:13, Bedia, Vaibhav wrote:
> On Mon, Nov 05, 2012 at 14:42:27, Philip, Avinash wrote:
> [...]
>
> > + /* Some platforms require explicit tbclk gating */
> > + if (of_property_read_bool(pdev->dev.of_node, "tbclkgating")) {
> > + pc->tbclk = clk_get(&pdev->dev, "tbclk");
> > + if (IS_ERR(pc->tbclk)) {
> > + dev_err(&pdev->dev, "Could not get EHRPWM TBCLK\n");
> > + return PTR_ERR(pc->tbclk);
> > + }
> > + }
> > +
> > + /* Enable tbclk & leave */
> > + if (pc->tbclk)
> > + clk_enable(pc->tbclk);
> > +
>
> Here also why are you leaving this clock always running?

This is an additional clock gating for EHRPWM functional clock from
control module. The enabling of this clock to pwm_enable
& disabling to pwm_disable. I will correct it.

Thanks
Avinash

>
> Regards,
> Vaibhav
>