> From: Joe Perches [[email protected]]
> ...
>On Thu, 2017-11-02 at 17:21 +0100, Aleksandar Markovic wrote:
> ...
>
> > Signed-off-by: Miodrag Dinic <[email protected]>
> > Signed-off-by: Goran Ferenc <[email protected]>
> > Signed-off-by: Aleksandar Markovic <[email protected]>
> > wq
>
> vi much?
>
:)
> > +/*
> > + * Driver for MIPS Goldfish Programmable Interrupt Controller.
> > + *
> > + * Author: Miodrag Dinic <[email protected]>
> > + *
> > + * This program is free software; you can redistribute it and/or modify it
> > + * under the terms of the GNU General Public License as published by the
> > + * Free Software Foundation; either version 2 of the License, or (at your
> > + * option) any later version.
> > + */
>
> Odd mix of spaces and tabs
>
Will be fixed in v8.
> It'd be good to add a #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> before any #include so the pr_<level> output is prefixed appropriately.
Error and info messages will be completely revised in v8.
Thanks for the review!
Aleksandar
From 1582972837905265840@xxx Thu Nov 02 16:35:39 +0000 2017
X-GM-THRID: 1582972112601312976
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread