The memset() is unnecessary since kzalloc already zero's the memory.
The platform resource is properly defined so use resource_size()
instead of the magic number DW_REGLEN for the ioremap() and
{request/release}_mem_region().
Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Haavard Skinnemoen <[email protected]>
---
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 2eea823..97ea99a 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
@@ -1265,14 +1265,13 @@ static int __init dw_probe(struct platform_device *pdev)
if (!dw)
return -ENOMEM;
- if (!request_mem_region(io->start, DW_REGLEN, pdev->dev.driver->name)) {
+ if (!request_mem_region(io->start, resource_size(io),
+ pdev->dev.driver->name)) {
err = -EBUSY;
goto err_kfree;
}
- memset(dw, 0, sizeof *dw);
-
- dw->regs = ioremap(io->start, DW_REGLEN);
+ dw->regs = ioremap(io->start, resource_size(io));
if (!dw->regs) {
err = -ENOMEM;
goto err_release_r;
@@ -1392,7 +1391,7 @@ static int __exit dw_remove(struct platform_device *pdev)
dw->regs = NULL;
io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- release_mem_region(io->start, DW_REGLEN);
+ release_mem_region(io->start, resource_size(io));
kfree(dw);