2023-05-09 02:33:53

by Wang Honghui

Subject: [PATCH V2] locking: Fix a typo of comment

As title

Signed-off-by: Wang Honghui <[email protected]>
---
kernel/locking/mutex.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c
index d973fe6041bf..fe7335fb63d4 100644
--- a/kernel/locking/mutex.c
+++ b/kernel/locking/mutex.c
@@ -362,7 +362,7 @@ bool mutex_spin_on_owner(struct mutex *lock, struct task_struct *owner,
* checking lock->owner still matches owner. And we already
* disabled preemption which is equal to the RCU read-side
* crital section in optimistic spinning code. Thus the
- * task_strcut structure won't go away during the spinning
+ * task_struct structure won't go away during the spinning
* period
*/
barrier();
@@ -401,7 +401,7 @@ static inline int mutex_can_spin_on_owner(struct mutex *lock)

/*
* We already disabled preemption which is equal to the RCU read-side
- * crital section in optimistic spinning code. Thus the task_strcut
+ * crital section in optimistic spinning code. Thus the task_struct
* structure won't go away during the spinning period.
*/
owner = __mutex_owner(lock);
--
2.34.1

2023-05-09 03:00:15

by Randy Dunlap

Subject: Re: [PATCH V2] locking: Fix a typo of comment

On 5/8/23 19:24, Wang Honghui wrote:
>
> As title
>
> Signed-off-by: Wang Honghui <[email protected]>
> ---
> kernel/locking/mutex.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c
> index d973fe6041bf..fe7335fb63d4 100644
> --- a/kernel/locking/mutex.c
> +++ b/kernel/locking/mutex.c
> @@ -362,7 +362,7 @@ bool mutex_spin_on_owner(struct mutex *lock, struct task_struct *owner,
> * checking lock->owner still matches owner. And we already
> * disabled preemption which is equal to the RCU read-side
> * crital section in optimistic spinning code. Thus the

critical

> - * task_strcut structure won't go away during the spinning
> + * task_struct structure won't go away during the spinning
> * period

period.

> */
> barrier();
> @@ -401,7 +401,7 @@ static inline int mutex_can_spin_on_owner(struct mutex *lock)
>
> /*
> * We already disabled preemption which is equal to the RCU read-side
> - * crital section in optimistic spinning code. Thus the task_strcut
> + * crital section in optimistic spinning code. Thus the task_struct

critical

> * structure won't go away during the spinning period.
> */
> owner = __mutex_owner(lock);

--
~Randy