Disable SERIAL_8250_PCI1XXXX config by default
Signed-off-by: Kumaravel Thiagarajan <[email protected]>
---
drivers/tty/serial/8250/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index 978dc196c29b..cbf11147dc89 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -299,7 +299,6 @@ config SERIAL_8250_PCI1XXXX
tristate "Microchip 8250 based serial port"
depends on SERIAL_8250 && PCI
select SERIAL_8250_PCILIB
- default SERIAL_8250
help
Select this option if you have a setup with Microchip PCIe
Switch with serial port enabled and wish to enable 8250
--
2.25.1
On Wed, Mar 01, 2023 at 03:39:30PM +0530, Kumaravel Thiagarajan wrote:
> Disable SERIAL_8250_PCI1XXXX config by default
Why?
Please read the kernel documentation for how to write a good changelog
text.
>
> Signed-off-by: Kumaravel Thiagarajan <[email protected]>
What commit id does this fix?
thanks,
greg k-h
On Wed, Mar 01, 2023 at 12:25:06PM +0100, Greg KH wrote:
> On Wed, Mar 01, 2023 at 03:39:30PM +0530, Kumaravel Thiagarajan wrote:
> > Disable SERIAL_8250_PCI1XXXX config by default
>
> Why?
>
> Please read the kernel documentation for how to write a good changelog
> text.
Kumaravel, hint for you: Take what Linus had written in the discussion of
Greg's pull request. It mainly explains it all.
> > Signed-off-by: Kumaravel Thiagarajan <[email protected]>
>
> What commit id does this fix?
Another hint: this lacks so called Fixes tag. You may read about it in the
documentation.
--
With Best Regards,
Andy Shevchenko
> -----Original Message-----
> From: Andy Shevchenko <[email protected]>
> Sent: Wednesday, March 1, 2023 9:23 PM
> On Wed, Mar 01, 2023 at 12:25:06PM +0100, Greg KH wrote:
> > On Wed, Mar 01, 2023 at 03:39:30PM +0530, Kumaravel Thiagarajan wrote:
> > > Disable SERIAL_8250_PCI1XXXX config by default
> >
> > Why?
> >
> > Please read the kernel documentation for how to write a good changelog
> > text.
>
> Kumaravel, hint for you: Take what Linus had written in the discussion of
> Greg's pull request. It mainly explains it all.
Thank you, Andy. I will do this.
>
> > > Signed-off-by: Kumaravel Thiagarajan
> > > <[email protected]>
> >
> > What commit id does this fix?
>
> Another hint: this lacks so called Fixes tag. You may read about it in the
> documentation.
Thank you for this too. I somehow missed this.
Regards,
Kumar