select:false makes the schema basically ignored and not effective, which
is clearly not what we want for a device binding.
Fixes: 352546805a44 ("dt-bindings: clock: Add bindings for versal clock driver")
Cc: <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Cc: Shubhrajyoti Datta <[email protected]>
---
Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml | 2 --
1 file changed, 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
index e9cf747bf89b..04ea327d5313 100644
--- a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
+++ b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
@@ -14,8 +14,6 @@ description: |
reads required input clock frequencies from the devicetree and acts as clock
provider for all clock consumers of PS clocks.
-select: false
-
properties:
compatible:
oneOf:
--
2.34.1
On Fri, Jul 28, 2023 at 06:59:23PM +0200, Krzysztof Kozlowski wrote:
> select:false makes the schema basically ignored and not effective, which
> is clearly not what we want for a device binding.
>
> Fixes: 352546805a44 ("dt-bindings: clock: Add bindings for versal clock driver")
> Cc: <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Thanks for spotting it!
Validation of the other patch seems to function as intended with this
applied.
Reviewed-by: Conor Dooley <[email protected]>
Thanks,
Conor.
>
> ---
>
> Cc: Shubhrajyoti Datta <[email protected]>
> ---
> Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> index e9cf747bf89b..04ea327d5313 100644
> --- a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> +++ b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> @@ -14,8 +14,6 @@ description: |
> reads required input clock frequencies from the devicetree and acts as clock
> provider for all clock consumers of PS clocks.
>
> -select: false
> -
> properties:
> compatible:
> oneOf:
> --
> 2.34.1
>
[AMD Official Use Only - General]
> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Friday, July 28, 2023 10:29 PM
> To: Michael Turquette <[email protected]>; Stephen Boyd
> <[email protected]>; Rob Herring <[email protected]>; Krzysztof
> Kozlowski <[email protected]>; Conor Dooley
> <[email protected]>; Simek, Michal <[email protected]>; Rajan
> Vaja <[email protected]>; [email protected];
> [email protected]; [email protected]
> Cc: Krzysztof Kozlowski <[email protected]>;
> [email protected]; Datta, Shubhrajyoti <[email protected]>
> Subject: [PATCH] dt-bindings: clock: xlnx,versal-clk: drop select:false
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> select:false makes the schema basically ignored and not effective, which is
> clearly not what we want for a device binding.
>
> Fixes: 352546805a44 ("dt-bindings: clock: Add bindings for versal clock
> driver")
> Cc: <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
Reviewed-by: Shubhrajyoti Datta <[email protected]>
Quoting Krzysztof Kozlowski (2023-07-28 09:59:23)
> select:false makes the schema basically ignored and not effective, which
> is clearly not what we want for a device binding.
>
> Fixes: 352546805a44 ("dt-bindings: clock: Add bindings for versal clock driver")
> Cc: <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
Applied to clk-next