2020-08-02 11:16:43

by Tianjia Zhang

Subject: [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init_request()

On an error exit path, a negative error code should be returned
instead of a positive return value.

Fixes: e399441de9115 ("nvme-fabrics: Add host support for FC transport")
Cc: James Smart <[email protected]>
Signed-off-by: Tianjia Zhang <[email protected]>
---
drivers/nvme/host/fc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index e999a8c4b7e8..2e06f8f4cff1 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -2075,7 +2075,7 @@ __nvme_fc_init_request(struct nvme_fc_ctrl *ctrl,
if (fc_dma_mapping_error(ctrl->lport->dev, op->fcp_req.cmddma)) {
dev_err(ctrl->dev,
"FCP Op failed - cmdiu dma mapping failed.\n");
- ret = EFAULT;
+ ret = -EFAULT;
goto out_on_error;
}

@@ -2085,7 +2085,7 @@ __nvme_fc_init_request(struct nvme_fc_ctrl *ctrl,
if (fc_dma_mapping_error(ctrl->lport->dev, op->fcp_req.rspdma)) {
dev_err(ctrl->dev,
"FCP Op failed - rspiu dma mapping failed.\n");
- ret = EFAULT;
+ ret = -EFAULT;
}

atomic_set(&op->state, FCPOP_STATE_IDLE);
--
2.26.2

2020-08-02 22:58:05

by Chaitanya Kulkarni

Subject: Re: [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init_request()

On 8/2/20 04:22, Tianjia Zhang wrote:
> On an error exit path, a negative error code should be returned
> instead of a positive return value.
>
> Fixes: e399441de9115 ("nvme-fabrics: Add host support for FC transport")
> Cc: James Smart<[email protected]>
> Signed-off-by: Tianjia Zhang<[email protected]>

Looks good.

Reviewed-by: Chaitanya Kulkarni <[email protected]>

2020-08-14 08:22:32

by Christoph Hellwig

Subject: Re: [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init_request()

On Sun, Aug 02, 2020 at 07:15:45PM +0800, Tianjia Zhang wrote:
> On an error exit path, a negative error code should be returned
> instead of a positive return value.
>
> Fixes: e399441de9115 ("nvme-fabrics: Add host support for FC transport")
> Cc: James Smart <[email protected]>
> Signed-off-by: Tianjia Zhang <[email protected]>

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>