2020-09-16 06:24:45

by Qinglang Miao

Subject: [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()

The mutex bnx2i_dev_lock is initialized statically. It is
unnecessary to initialize by mutex_init().

Signed-off-by: Qinglang Miao <[email protected]>
---
drivers/scsi/bnx2i/bnx2i_init.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
index 6018cdd17..2b3f0c104 100644
--- a/drivers/scsi/bnx2i/bnx2i_init.c
+++ b/drivers/scsi/bnx2i/bnx2i_init.c
@@ -474,8 +474,6 @@ static int __init bnx2i_mod_init(void)
if (sq_size && !is_power_of_2(sq_size))
sq_size = roundup_pow_of_two(sq_size);

- mutex_init(&bnx2i_dev_lock);
-
bnx2i_scsi_xport_template =
iscsi_register_transport(&bnx2i_iscsi_transport);
if (!bnx2i_scsi_xport_template) {
--
2.23.0

2020-09-16 09:19:26

by Manish Rangankar

Subject: RE: [EXT] [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()

> -----Original Message-----
> From: Qinglang Miao <[email protected]>
> Sent: Wednesday, September 16, 2020 11:52 AM
> To: Nilesh Javali <[email protected]>; Manish Rangankar
> <[email protected]>; GR-QLogic-Storage-Upstream <GR-QLogic-
> [email protected]>; James E.J. Bottomley
> <[email protected]>; Martin K. Petersen <[email protected]>
> Cc: [email protected]; [email protected]; Qinglang Miao
> <[email protected]>
> Subject: [EXT] [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()
>
> External Email
>
> ----------------------------------------------------------------------
> The mutex bnx2i_dev_lock is initialized statically. It is unnecessary to
> initialize by mutex_init().
>
> Signed-off-by: Qinglang Miao <[email protected]>
> ---
> drivers/scsi/bnx2i/bnx2i_init.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
> index 6018cdd17..2b3f0c104 100644
> --- a/drivers/scsi/bnx2i/bnx2i_init.c
> +++ b/drivers/scsi/bnx2i/bnx2i_init.c
> @@ -474,8 +474,6 @@ static int __init bnx2i_mod_init(void)
> if (sq_size && !is_power_of_2(sq_size))
> sq_size = roundup_pow_of_two(sq_size);
>
> - mutex_init(&bnx2i_dev_lock);
> -
> bnx2i_scsi_xport_template =
> iscsi_register_transport(&bnx2i_iscsi_transport);
> if (!bnx2i_scsi_xport_template) {
> --

Thanks,
Acked-by: Manish Rangankar <[email protected]>

2020-09-23 01:04:40

by Martin K. Petersen

Subject: Re: [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()

Qinglang,

> The mutex bnx2i_dev_lock is initialized statically. It is
> unnecessary to initialize by mutex_init().

Applied to 5.10/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2020-09-30 03:39:29

by Martin K. Petersen

Subject: Re: [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()

On Wed, 16 Sep 2020 14:21:33 +0800, Qinglang Miao wrote:

> The mutex bnx2i_dev_lock is initialized statically. It is
> unnecessary to initialize by mutex_init().

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: bnx2i: Remove unnecessary mutex_init()
https://git.kernel.org/mkp/scsi/c/97d0e04d38b4

--
Martin K. Petersen Oracle Linux Engineering