2023-09-30 08:45:48

by Randy Dunlap

Subject: [PATCH] hyperv: rndis_filter needs to select NLS

rndis_filter uses utf8s_to_utf16s() which is provided by setting
NLS, so select NLS to fix the build error:

ERROR: modpost: "utf8s_to_utf16s" [drivers/net/hyperv/hv_netvsc.ko] undefined!

Fixes: 1ce09e899d28 ("hyperv: Add support for setting MAC from within guests")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Haiyang Zhang <[email protected]>
Cc: K. Y. Srinivasan <[email protected]>
Cc: Wei Liu <[email protected]>
Cc: Dexuan Cui <[email protected]>
Cc: [email protected]
Cc: David S. Miller <[email protected]>
Cc: Eric Dumazet <[email protected]>
Cc: Jakub Kicinski <[email protected]>
Cc: Paolo Abeni <[email protected]>
Cc: [email protected]
---
drivers/net/hyperv/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff -- a/drivers/net/hyperv/Kconfig b/drivers/net/hyperv/Kconfig
--- a/drivers/net/hyperv/Kconfig
+++ b/drivers/net/hyperv/Kconfig
@@ -3,5 +3,6 @@ config HYPERV_NET
tristate "Microsoft Hyper-V virtual network driver"
depends on HYPERV
select UCS2_STRING
+ select NLS
help
Select this option to enable the Hyper-V virtual network driver.

2023-10-03 10:29:41

by Simon Horman

Subject: Re: [PATCH] hyperv: rndis_filter needs to select NLS

On Fri, Sep 29, 2023 at 07:32:34PM -0700, Randy Dunlap wrote:
> rndis_filter uses utf8s_to_utf16s() which is provided by setting
> NLS, so select NLS to fix the build error:
>
> ERROR: modpost: "utf8s_to_utf16s" [drivers/net/hyperv/hv_netvsc.ko] undefined!
>
> Fixes: 1ce09e899d28 ("hyperv: Add support for setting MAC from within guests")
> Signed-off-by: Randy Dunlap <[email protected]>

Reviewed-by: Simon Horman <[email protected]>
Tested-by: Simon Horman <[email protected]> # build-tested

2023-10-03 17:13:06

by Michael Kelley (LINUX)

Subject: RE: [PATCH] hyperv: rndis_filter needs to select NLS

From: Randy Dunlap <[email protected]> Sent: Friday, September 29, 2023 7:33 PM
>

Patches for this driver usually use the subject prefix "hv_netvsc: ", not "hyperv".
Other than that minor tweak,

Reviewed-by: Michael Kelley <[email protected]>

> rndis_filter uses utf8s_to_utf16s() which is provided by setting
> NLS, so select NLS to fix the build error:
>
> ERROR: modpost: "utf8s_to_utf16s" [drivers/net/hyperv/hv_netvsc.ko] undefined!
>
> Fixes: 1ce09e899d28 ("hyperv: Add support for setting MAC from within guests")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Haiyang Zhang <[email protected]>
> Cc: K. Y. Srinivasan <[email protected]>
> Cc: Wei Liu <[email protected]>
> Cc: Dexuan Cui <[email protected]>
> Cc: [email protected]
> Cc: David S. Miller <[email protected]>
> Cc: Eric Dumazet <[email protected]>
> Cc: Jakub Kicinski <[email protected]>
> Cc: Paolo Abeni <[email protected]>
> Cc: [email protected]
> ---
> drivers/net/hyperv/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/net/hyperv/Kconfig b/drivers/net/hyperv/Kconfig
> --- a/drivers/net/hyperv/Kconfig
> +++ b/drivers/net/hyperv/Kconfig
> @@ -3,5 +3,6 @@ config HYPERV_NET
> tristate "Microsoft Hyper-V virtual network driver"
> depends on HYPERV
> select UCS2_STRING
> + select NLS
> help
> Select this option to enable the Hyper-V virtual network driver.