2023-07-09 11:16:47

by Sui Jingfeng

[permalink] [raw]
Subject: [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h

drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
>> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first use in this function)
1033 | base = screen_info.lfb_base;
| ^~~~~~~~~~~
drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is reported only once for each function it appears in
--
drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared (first use in this function)
75 | drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
| ^~~~~~~~~~~
drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared identifier is reported only once for each function it appears in

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
Signed-off-by: Sui Jingfeng <[email protected]>
---
drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
index a7d2c92d6c6a..8026118c6e03 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
@@ -7,6 +7,7 @@
#include <linux/hyperv.h>
#include <linux/module.h>
#include <linux/pci.h>
+#include <linux/screen_info.h>

#include <drm/drm_aperture.h>
#include <drm/drm_atomic_helper.h>
--
2.25.1



2023-07-09 14:57:47

by Thomas Zimmermann

[permalink] [raw]
Subject: Re: [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h

Hi

Am 09.07.23 um 12:05 schrieb Sui Jingfeng:
> drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
>>> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first use in this function)
> 1033 | base = screen_info.lfb_base;
> | ^~~~~~~~~~~
> drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is reported only once for each function it appears in
> --
> drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
>>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared (first use in this function)
> 75 | drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
> | ^~~~~~~~~~~
> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared identifier is reported only once for each function it appears in
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
> Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
> Signed-off-by: Sui Jingfeng <[email protected]>

Reviewed-by: Thomas Zimmermann <[email protected]>

Thanks for the patch.

Best regards
Thomas


> ---
> drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> index a7d2c92d6c6a..8026118c6e03 100644
> --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> @@ -7,6 +7,7 @@
> #include <linux/hyperv.h>
> #include <linux/module.h>
> #include <linux/pci.h>
> +#include <linux/screen_info.h>
>
> #include <drm/drm_aperture.h>
> #include <drm/drm_atomic_helper.h>

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)


Attachments:
OpenPGP_signature (855.00 B)
OpenPGP digital signature

2023-07-10 05:58:59

by Michael Kelley (LINUX)

[permalink] [raw]
Subject: RE: [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h

From: Sui Jingfeng <[email protected]> Sent: Sunday, July 9, 2023 3:05 AM
>
> drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
> >> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first use
> in this function)
> 1033 | base = screen_info.lfb_base;
> | ^~~~~~~~~~~
> drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is reported
> only once for each function it appears in
> --
> drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
> >> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared
> (first use in this function)
> 75 | drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
> | ^~~~~~~~~~~
> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared identifier is
> reported only once for each function it appears in
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
> Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
> Signed-off-by: Sui Jingfeng <[email protected]>
> ---
> drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> index a7d2c92d6c6a..8026118c6e03 100644
> --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> @@ -7,6 +7,7 @@
> #include <linux/hyperv.h>
> #include <linux/module.h>
> #include <linux/pci.h>
> +#include <linux/screen_info.h>
>
> #include <drm/drm_aperture.h>
> #include <drm/drm_atomic_helper.h>
> --
> 2.25.1

Reviewed-by: Michael Kelley <[email protected]>

2023-07-10 06:54:55

by Sui Jingfeng

[permalink] [raw]
Subject: Re: [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h

OK, thanks a lot,

done!

On 2023/7/10 13:20, Michael Kelley (LINUX) wrote:
> From: Sui Jingfeng <[email protected]> Sent: Sunday, July 9, 2023 3:05 AM
>> drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
>>>> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first use
>> in this function)
>> 1033 | base = screen_info.lfb_base;
>> | ^~~~~~~~~~~
>> drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is reported
>> only once for each function it appears in
>> --
>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
>>>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared
>> (first use in this function)
>> 75 | drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
>> | ^~~~~~~~~~~
>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared identifier is
>> reported only once for each function it appears in
>>
>> Reported-by: kernel test robot <[email protected]>
>> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
>> Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
>> Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
>> Signed-off-by: Sui Jingfeng <[email protected]>
>> ---
>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> index a7d2c92d6c6a..8026118c6e03 100644
>> --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> @@ -7,6 +7,7 @@
>> #include <linux/hyperv.h>
>> #include <linux/module.h>
>> #include <linux/pci.h>
>> +#include <linux/screen_info.h>
>>
>> #include <drm/drm_aperture.h>
>> #include <drm/drm_atomic_helper.h>
>> --
>> 2.25.1
> Reviewed-by: Michael Kelley <[email protected]>