Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree")
breaks arc:defconfig build:
drivers/built-in.o: In function `of_setup_earlycon':
(.init.text+0xb3e): undefined reference to `arc_early_base_baud'
drivers/built-in.o: In function `setup_earlycon':
(.init.text+0xcd0): undefined reference to `arc_early_base_baud'
make: *** [vmlinux] Error 1
BASE_BAUD is only required for earlycon, which should depend on
CONFIG_SERIAL_EARLYCON.
Reported-by: Guenter Roeck <[email protected]>
Tested-by: Guenter Roeck <[email protected]>
Signed-off-by: Peter Hurley <[email protected]>
---
arch/arc/kernel/devtree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arc/kernel/devtree.c b/arch/arc/kernel/devtree.c
index 5036d4c..e32b54a 100644
--- a/arch/arc/kernel/devtree.c
+++ b/arch/arc/kernel/devtree.c
@@ -17,7 +17,7 @@
#include <asm/clk.h>
#include <asm/mach_desc.h>
-#ifdef CONFIG_SERIAL_8250_CONSOLE
+#ifdef CONFIG_SERIAL_EARLYCON
static unsigned int __initdata arc_base_baud;
--
2.2.2
On Tue, Feb 03, 2015 at 08:08:52PM -0500, Peter Hurley wrote:
> Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree")
> breaks arc:defconfig build:
I don't see that commit id in my trees, so why send this to me? Where
did you find it?
confused,
greg k-h
On 02/03/2015 08:16 PM, Greg Kroah-Hartman wrote:
> On Tue, Feb 03, 2015 at 08:08:52PM -0500, Peter Hurley wrote:
>> Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree")
>> breaks arc:defconfig build:
>
> I don't see that commit id in my trees, so why send this to me?
Sorry. The earlier version of this patch was originally submitted to you,
but I forgot that since all the tty parts were cut out (at my urging :/),
it went through Vineet's tree directly.
Regards,
Peter Hurley
Hi Greg,
On Tue, 3 Feb 2015 17:16:35 -0800 Greg Kroah-Hartman <[email protected]> wrote:
>
> On Tue, Feb 03, 2015 at 08:08:52PM -0500, Peter Hurley wrote:
> > Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree")
> > breaks arc:defconfig build:
>
> I don't see that commit id in my trees, so why send this to me? Where
> did you find it?
It comes from the arc tree. So, yes, not your concern.
--
Cheers,
Stephen Rothwell [email protected]
On Wednesday 04 February 2015 06:39 AM, Peter Hurley wrote:
> Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree")
> breaks arc:defconfig build:
>
> drivers/built-in.o: In function `of_setup_earlycon':
> (.init.text+0xb3e): undefined reference to `arc_early_base_baud'
> drivers/built-in.o: In function `setup_earlycon':
> (.init.text+0xcd0): undefined reference to `arc_early_base_baud'
> make: *** [vmlinux] Error 1
>
> BASE_BAUD is only required for earlycon, which should depend on
> CONFIG_SERIAL_EARLYCON.
>
> Reported-by: Guenter Roeck <[email protected]>
> Tested-by: Guenter Roeck <[email protected]>
> Signed-off-by: Peter Hurley <[email protected]>
/Me slaps myself :-(
Thx for the quick fix Peter. Now applied to my for-next and also quickly tested on
simulator.
FWIW, the issue came about because defconfig doesn't use the 8250 uart driver,
rather the legacy arc uart which still uses earlycon - but I still can't fathom
why i didn't see it earlier.
Thx,
-Vineet
> ---
> arch/arc/kernel/devtree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arc/kernel/devtree.c b/arch/arc/kernel/devtree.c
> index 5036d4c..e32b54a 100644
> --- a/arch/arc/kernel/devtree.c
> +++ b/arch/arc/kernel/devtree.c
> @@ -17,7 +17,7 @@
> #include <asm/clk.h>
> #include <asm/mach_desc.h>
>
> -#ifdef CONFIG_SERIAL_8250_CONSOLE
> +#ifdef CONFIG_SERIAL_EARLYCON
>
> static unsigned int __initdata arc_base_baud;
>