2021-07-21 10:38:49

by Stanislav Yakovlev

[permalink] [raw]
Subject: Re: [PATCH] ipw2x00: Use struct_size helper instead of open-coded arithmetic

On Sat, 17 Jul 2021 at 18:25, Len Baker <[email protected]> wrote:
>
> Dynamic size calculations (especially multiplication) should not be
> performed in memory allocator function arguments due to the risk of them
> overflowing. This could lead to values wrapping around and a smaller
> allocation being made than the caller was expecting. Using those
> allocations could lead to linear overflows of heap memory and other
> misbehaviors.
>
> To avoid this scenario, use the struct_size helper.
>
> Signed-off-by: Len Baker <[email protected]>
> ---
> drivers/net/wireless/intel/ipw2x00/libipw_tx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Looks fine, thanks!

Stanislav.