2024-01-17 03:13:41

by Erico Nunes

Subject: [PATCH v1 6/6] drm/lima: improve some pp debug messages

Make the messages more consistent by showing the pp name.

Signed-off-by: Erico Nunes <[email protected]>
---
drivers/gpu/drm/lima/lima_pp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/lima/lima_pp.c b/drivers/gpu/drm/lima/lima_pp.c
index ac097dd75072..d9e178d6645d 100644
--- a/drivers/gpu/drm/lima/lima_pp.c
+++ b/drivers/gpu/drm/lima/lima_pp.c
@@ -197,7 +197,7 @@ static int lima_pp_hard_reset(struct lima_ip *ip)
pp_write(LIMA_PP_CTRL, LIMA_PP_CTRL_FORCE_RESET);
ret = lima_poll_timeout(ip, lima_pp_hard_reset_poll, 10, 100);
if (ret) {
- dev_err(dev->dev, "pp hard reset timeout\n");
+ dev_err(dev->dev, "pp %s hard reset timeout\n", lima_ip_name(ip));
return ret;
}

@@ -423,8 +423,8 @@ static void lima_pp_task_error(struct lima_sched_pipe *pipe)
for (i = 0; i < pipe->num_processor; i++) {
struct lima_ip *ip = pipe->processor[i];

- dev_err(ip->dev->dev, "pp task error %d int_state=%x status=%x\n",
- i, pp_read(LIMA_PP_INT_STATUS), pp_read(LIMA_PP_STATUS));
+ dev_err(ip->dev->dev, "pp %s task error int_state=%x status=%x\n",
+ lima_ip_name(ip), pp_read(LIMA_PP_INT_STATUS), pp_read(LIMA_PP_STATUS));

lima_pp_hard_reset(ip);
}
--
2.43.0

2024-01-17 18:29:58

by Vasily Khoruzhick

Subject: Re: [PATCH v1 6/6] drm/lima: improve some pp debug messages

On Tue, Jan 16, 2024 at 7:12 PM Erico Nunes <[email protected]> wrote:
>
> Make the messages more consistent by showing the pp name.
>
> Signed-off-by: Erico Nunes <[email protected]>
Reviewed-by: Vasily Khoruzhick <[email protected]>

> ---
> drivers/gpu/drm/lima/lima_pp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_pp.c b/drivers/gpu/drm/lima/lima_pp.c
> index ac097dd75072..d9e178d6645d 100644
> --- a/drivers/gpu/drm/lima/lima_pp.c
> +++ b/drivers/gpu/drm/lima/lima_pp.c
> @@ -197,7 +197,7 @@ static int lima_pp_hard_reset(struct lima_ip *ip)
> pp_write(LIMA_PP_CTRL, LIMA_PP_CTRL_FORCE_RESET);
> ret = lima_poll_timeout(ip, lima_pp_hard_reset_poll, 10, 100);
> if (ret) {
> - dev_err(dev->dev, "pp hard reset timeout\n");
> + dev_err(dev->dev, "pp %s hard reset timeout\n", lima_ip_name(ip));
> return ret;
> }
>
> @@ -423,8 +423,8 @@ static void lima_pp_task_error(struct lima_sched_pipe *pipe)
> for (i = 0; i < pipe->num_processor; i++) {
> struct lima_ip *ip = pipe->processor[i];
>
> - dev_err(ip->dev->dev, "pp task error %d int_state=%x status=%x\n",
> - i, pp_read(LIMA_PP_INT_STATUS), pp_read(LIMA_PP_STATUS));
> + dev_err(ip->dev->dev, "pp %s task error int_state=%x status=%x\n",
> + lima_ip_name(ip), pp_read(LIMA_PP_INT_STATUS), pp_read(LIMA_PP_STATUS));
>
> lima_pp_hard_reset(ip);
> }
> --
> 2.43.0
>