2019-09-12 09:00:34

by Yannick FERTRE

Subject: [PATCH] drm/stm: dsi: higher pll out only in video burst mode

In order to better support video non-burst modes,
the +20% on pll out is added only in burst mode.

Signed-off-by: Philippe Cornu <[email protected]>
Reviewed-by: Yannick FERTRE <[email protected]>
---
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
index a03a642..514efef 100644
--- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
+++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
@@ -260,8 +260,11 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const struct drm_display_mode *mode,
/* Compute requested pll out */
bpp = mipi_dsi_pixel_format_to_bpp(format);
pll_out_khz = mode->clock * bpp / lanes;
+
/* Add 20% to pll out to be higher than pixel bw (burst mode only) */
- pll_out_khz = (pll_out_khz * 12) / 10;
+ if (mode_flags & MIPI_DSI_MODE_VIDEO_BURST)
+ pll_out_khz = (pll_out_khz * 12) / 10;
+
if (pll_out_khz > dsi->lane_max_kbps) {
pll_out_khz = dsi->lane_max_kbps;
DRM_WARN("Warning max phy mbps is used\n");
--
2.7.4

2019-09-16 20:30:51

by Benjamin Gaignard

Subject: Re: [PATCH] drm/stm: dsi: higher pll out only in video burst mode

Le jeu. 12 sept. 2019 à 10:57, Yannick Fertré <[email protected]> a écrit :
>
> In order to better support video non-burst modes,
> the +20% on pll out is added only in burst mode.
>
> Signed-off-by: Philippe Cornu <[email protected]>
> Reviewed-by: Yannick FERTRE <[email protected]>

Applied on drm-misc-next,
Thanks,
Benjamin

> ---
> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> index a03a642..514efef 100644
> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> @@ -260,8 +260,11 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const struct drm_display_mode *mode,
> /* Compute requested pll out */
> bpp = mipi_dsi_pixel_format_to_bpp(format);
> pll_out_khz = mode->clock * bpp / lanes;
> +
> /* Add 20% to pll out to be higher than pixel bw (burst mode only) */
> - pll_out_khz = (pll_out_khz * 12) / 10;
> + if (mode_flags & MIPI_DSI_MODE_VIDEO_BURST)
> + pll_out_khz = (pll_out_khz * 12) / 10;
> +
> if (pll_out_khz > dsi->lane_max_kbps) {
> pll_out_khz = dsi->lane_max_kbps;
> DRM_WARN("Warning max phy mbps is used\n");
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel