2014-07-08 15:26:07

by Lad, Prabhakar

Subject: [PATCH] cpufreq: Makefile: fix compilation for davinci platform

>From patch with commt-id:8a7b1227e303d7e927214ee0f260041aef44bb58
"cpufreq: davinci: move cpufreq driver to drivers/cpufreq"
this added dependancy only for CONFIG_ARCH_DAVINCI_DA850 where as
davinci_cpufreq_init() call is used by all davinci platform.

This patch fixes following build error:

arch/arm/mach-davinci/built-in.o: In function `davinci_init_late':
:(.init.text+0x928): undefined reference to `davinci_cpufreq_init'
make: *** [vmlinux] Error 1

Signed-off-by: Lad, Prabhakar <[email protected]>
---
drivers/cpufreq/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
index 738c8b7..db6d9a2 100644
--- a/drivers/cpufreq/Makefile
+++ b/drivers/cpufreq/Makefile
@@ -49,7 +49,7 @@ obj-$(CONFIG_ARM_BIG_LITTLE_CPUFREQ) += arm_big_little.o
# LITTLE drivers, so that it is probed last.
obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o

-obj-$(CONFIG_ARCH_DAVINCI_DA850) += davinci-cpufreq.o
+obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += exynos-cpufreq.o
obj-$(CONFIG_ARM_EXYNOS4210_CPUFREQ) += exynos4210-cpufreq.o
--
1.9.1

2014-07-08 15:29:24

by Viresh Kumar

Subject: Re: [PATCH] cpufreq: Makefile: fix compilation for davinci platform

On 8 July 2014 20:55, Lad, Prabhakar <[email protected]> wrote:
> From patch with commt-id:8a7b1227e303d7e927214ee0f260041aef44bb58
> "cpufreq: davinci: move cpufreq driver to drivers/cpufreq"
> this added dependancy only for CONFIG_ARCH_DAVINCI_DA850 where as
> davinci_cpufreq_init() call is used by all davinci platform.
>
> This patch fixes following build error:
>
> arch/arm/mach-davinci/built-in.o: In function `davinci_init_late':
> :(.init.text+0x928): undefined reference to `davinci_cpufreq_init'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Lad, Prabhakar <[email protected]>
> ---
> drivers/cpufreq/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index 738c8b7..db6d9a2 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -49,7 +49,7 @@ obj-$(CONFIG_ARM_BIG_LITTLE_CPUFREQ) += arm_big_little.o
> # LITTLE drivers, so that it is probed last.
> obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
>
> -obj-$(CONFIG_ARCH_DAVINCI_DA850) += davinci-cpufreq.o
> +obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
> obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
> obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += exynos-cpufreq.o
> obj-$(CONFIG_ARM_EXYNOS4210_CPUFREQ) += exynos4210-cpufreq.o

It took one year and 5 kernel releases to catch this again?

Acked-by: Viresh Kumar <[email protected]>

2014-07-08 15:33:30

by Lad, Prabhakar

Subject: Re: [PATCH] cpufreq: Makefile: fix compilation for davinci platform

On Tue, Jul 8, 2014 at 4:29 PM, Viresh Kumar <[email protected]> wrote:
> On 8 July 2014 20:55, Lad, Prabhakar <[email protected]> wrote:
>> From patch with commt-id:8a7b1227e303d7e927214ee0f260041aef44bb58
>> "cpufreq: davinci: move cpufreq driver to drivers/cpufreq"
>> this added dependancy only for CONFIG_ARCH_DAVINCI_DA850 where as
>> davinci_cpufreq_init() call is used by all davinci platform.
>>
>> This patch fixes following build error:
>>
>> arch/arm/mach-davinci/built-in.o: In function `davinci_init_late':
>> :(.init.text+0x928): undefined reference to `davinci_cpufreq_init'
>> make: *** [vmlinux] Error 1
>>
>> Signed-off-by: Lad, Prabhakar <[email protected]>
>> ---
>> drivers/cpufreq/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
>> index 738c8b7..db6d9a2 100644
>> --- a/drivers/cpufreq/Makefile
>> +++ b/drivers/cpufreq/Makefile
>> @@ -49,7 +49,7 @@ obj-$(CONFIG_ARM_BIG_LITTLE_CPUFREQ) += arm_big_little.o
>> # LITTLE drivers, so that it is probed last.
>> obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
>>
>> -obj-$(CONFIG_ARCH_DAVINCI_DA850) += davinci-cpufreq.o
>> +obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
>> obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
>> obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += exynos-cpufreq.o
>> obj-$(CONFIG_ARM_EXYNOS4210_CPUFREQ) += exynos4210-cpufreq.o
>
> It took one year and 5 kernel releases to catch this again?
>
For a long time I was been working on DA850 itself, so couldn’t
notice it :(.

> Acked-by: Viresh Kumar <[email protected]>

Thanks!

Regards,
--Prabhakar Lad