2021-03-13 03:43:41

by Pallavi Prabhu

Subject: [PATCH] clk: clk.c: Fixed statics initialized to 0

Uninitialized static variable from 0, as statics get auto-initialized to 0 during execution.
Signed-off-by: Pallavi Prabhu <[email protected]>
---
drivers/clk/clk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 5052541a0986..763ad2c960bd 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -2931,7 +2931,7 @@ EXPORT_SYMBOL_GPL(clk_is_match);
#include <linux/debugfs.h>

static struct dentry *rootdir;
-static int inited = 0;
+static int inited;
static DEFINE_MUTEX(clk_debug_lock);
static HLIST_HEAD(clk_debug_list);

--
2.25.1

2021-03-13 21:08:06

by Stephen Boyd

Subject: Re: [PATCH] clk: clk.c: Fixed statics initialized to 0

Quoting Pallavi Prabhu (2021-03-12 19:41:12)
> Uninitialized static variable from 0, as statics get auto-initialized to 0 during execution.
> Signed-off-by: Pallavi Prabhu <[email protected]>

Need a newline between signed-off-by line and commit text. Also please
wrap the commit text at 80 or 78 characters or so.

> ---
> drivers/clk/clk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 5052541a0986..763ad2c960bd 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -2931,7 +2931,7 @@ EXPORT_SYMBOL_GPL(clk_is_match);
> #include <linux/debugfs.h>
>
> static struct dentry *rootdir;
> -static int inited = 0;
> +static int inited;

I think it's being explicit; although it is the same. Is this noticed by
some static checker or something? I'd like to ignore this patch if
possible.

> static DEFINE_MUTEX(clk_debug_lock);
> static HLIST_HEAD(clk_debug_list);
>

2021-03-14 06:23:17

by Pallavi Prabhu

Subject: Re: [PATCH] clk: clk.c: Fixed statics initialized to 0

On Sun, 14 Mar 2021 at 02:36, Stephen Boyd <[email protected]> wrote:
>
> Quoting Pallavi Prabhu (2021-03-12 19:41:12)
> > Uninitialized static variable from 0, as statics get auto-initialized to 0 during execution.
> > Signed-off-by: Pallavi Prabhu <[email protected]>
>
> Need a newline between signed-off-by line and commit text. Also please
> wrap the commit text at 80 or 78 characters or so.
>
> > ---
> > drivers/clk/clk.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> > index 5052541a0986..763ad2c960bd 100644
> > --- a/drivers/clk/clk.c
> > +++ b/drivers/clk/clk.c
> > @@ -2931,7 +2931,7 @@ EXPORT_SYMBOL_GPL(clk_is_match);
> > #include <linux/debugfs.h>
> >
> > static struct dentry *rootdir;
> > -static int inited = 0;
> > +static int inited;
>
> I think it's being explicit; although it is the same. Is this noticed by
> some static checker or something? I'd like to ignore this patch if
> possible.
The Static variable initialized to 0 was noticed by the checkpatch.
This error message was corrected.
Would you want me to send a v2 with the proper commit text?