The mei_me driver prints "suspend" at error level at each suspend.
Downgrade that uninteresting message to debug level.
Signed-off-by: Paul Bolle <[email protected]>
---
Lightly tested (on top of v3.10.10, actually). Should apply cleanly to
v3.11 or current master.
Perhaps a better fix is to remove this message entirely.
drivers/misc/mei/pci-me.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
index 0f26832..02740fc 100644
--- a/drivers/misc/mei/pci-me.c
+++ b/drivers/misc/mei/pci-me.c
@@ -281,7 +281,7 @@ static int mei_me_pci_suspend(struct device *device)
if (!dev)
return -ENODEV;
- dev_err(&pdev->dev, "suspend\n");
+ dev_dbg(&pdev->dev, "suspend\n");
mei_stop(dev);
--
1.8.1.4
On Thu, 2013-09-12 at 21:17 +0200, Paul Bolle wrote:
> The mei_me driver prints "suspend" at error level at each suspend.
> Downgrade that uninteresting message to debug level.
>
> Signed-off-by: Paul Bolle <[email protected]>
> ---
> Lightly tested (on top of v3.10.10, actually). Should apply cleanly to
> v3.11 or current master.
>
> Perhaps a better fix is to remove this message entirely.
Rechecking my logs I noticed a "stop" error on module unload. That
message could be downgraded to debug level too. But it could also be
removed. If Tomas could say what is preferable I'll send a second
version of this trivial patch.
Paul Bolle
> >
> > Signed-off-by: Paul Bolle <[email protected]>
> > ---
> > Lightly tested (on top of v3.10.10, actually). Should apply cleanly to
> > v3.11 or current master.
> >
> > Perhaps a better fix is to remove this message entirely.
>
> Rechecking my logs I noticed a "stop" error on module unload. That
> message could be downgraded to debug level too. But it could also be
> removed. If Tomas could say what is preferable I'll send a second
> version of this trivial patch.
I prefer to have it on debug level.
Thanks
Tomas
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay? ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?
The mei_me driver prints "suspend" at error level at each suspend. It
also prints "stop" at error level at driver unload. Downgrade these
uninteresting messages to debug level.
Signed-off-by: Paul Bolle <[email protected]>
---
0) v1 was called "mei: me: downgrade "suspend" message to debug level".
v2 also downgrades the "stop" message.
1) Added Adam and Joe to Cc:. They were involved in discussing a patch
by Adam, which was similar to my v1, about a week ago.
2) Still lightly tested only, but now on top of v3.11.1.
drivers/misc/mei/pci-me.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
index 1b3844e..897ee6b 100644
--- a/drivers/misc/mei/pci-me.c
+++ b/drivers/misc/mei/pci-me.c
@@ -231,7 +231,7 @@ static void mei_me_remove(struct pci_dev *pdev)
hw = to_me_hw(dev);
- dev_err(&pdev->dev, "stop\n");
+ dev_dbg(&pdev->dev, "stop\n");
mei_stop(dev);
/* disable interrupts */
@@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
if (!dev)
return -ENODEV;
- dev_err(&pdev->dev, "suspend\n");
+ dev_dbg(&pdev->dev, "suspend\n");
mei_stop(dev);
--
1.8.1.4
On Thu, Sep 19, 2013 at 1:17 PM, Paul Bolle <[email protected]> wrote:
> The mei_me driver prints "suspend" at error level at each suspend. It
> also prints "stop" at error level at driver unload. Downgrade these
> uninteresting messages to debug level.
>
> Signed-off-by: Paul Bolle <[email protected]>
> ---
> 0) v1 was called "mei: me: downgrade "suspend" message to debug level".
> v2 also downgrades the "stop" message.
>
> 1) Added Adam and Joe to Cc:. They were involved in discussing a patch
> by Adam, which was similar to my v1, about a week ago.
>
> 2) Still lightly tested only, but now on top of v3.11.1.
>
> drivers/misc/mei/pci-me.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
> index 1b3844e..897ee6b 100644
> --- a/drivers/misc/mei/pci-me.c
> +++ b/drivers/misc/mei/pci-me.c
> @@ -231,7 +231,7 @@ static void mei_me_remove(struct pci_dev *pdev)
> hw = to_me_hw(dev);
>
>
> - dev_err(&pdev->dev, "stop\n");
> + dev_dbg(&pdev->dev, "stop\n");
> mei_stop(dev);
>
> /* disable interrupts */
> @@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
> if (!dev)
> return -ENODEV;
>
> - dev_err(&pdev->dev, "suspend\n");
> + dev_dbg(&pdev->dev, "suspend\n");
>
> mei_stop(dev);
>
> --
> 1.8.1.4
Ack
On Thu, 2013-09-26 at 11:56 +0300, Tomas Winkler wrote:
> On Thu, Sep 19, 2013 at 1:17 PM, Paul Bolle <[email protected]> wrote:
> > The mei_me driver prints "suspend" at error level at each suspend. It
> > also prints "stop" at error level at driver unload. Downgrade these
> > uninteresting messages to debug level.
> >
> > Signed-off-by: Paul Bolle <[email protected]>
>>[...]
>
> Ack
You're the same person as the Tomas Winkler with the intel.com address,
aren't you? If so, you're the maintainer of this code. That makes me
wonder what this Ack is supposed to mean.
Paul Bolle