2013-09-04 00:35:54

by Tomas Winkler

[permalink] [raw]
Subject: drivers/char/hpet.c ACPI parsing

In hpet_resources function

Can anybody explain why we check fixmem32 for NULL, looks strange as
it derreferences a member address

I'm asking since a static analyzer is complaining about it.

} else if (res->id == ACPI_RSTYPE_FIXED_MEM32) {
struct acpi_resource_fixed_mem32 *fixmem32;

fixmem32 = &res->data.fixed_memory32;
if (!fixmem32)
^^^^^^
return -EINVAL;

Thanks
Tomas