2020-03-13 18:04:54

by Rajat Jain

Subject: [PATCH v3] Input: Allocate keycode for "Selective Screenshot" key

New chromeos keyboards have a "snip" key that is basically a selective
screenshot (allows a user to select an area of screen to be copied).
Allocate a keycode for it.

Signed-off-by: Rajat Jain <[email protected]>
---
v3: Rename KEY_SNIP to KEY_SELECTIVE_SNAPSHOT
V2: Drop patch [1/2] and instead rebase this on top of Linus' tree.

include/uapi/linux/input-event-codes.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index 0f1db1cccc3fd..c4dbe2ee9c098 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -652,6 +652,8 @@
/* Electronic privacy screen control */
#define KEY_PRIVACY_SCREEN_TOGGLE 0x279

+#define KEY_SELECTIVE_SCREENSHOT 0x280
+
/*
* Some keyboards have keys which do not have a defined meaning, these keys
* are intended to be programmed / bound to macros by the user. For most
--
2.25.1.481.gfbce0eb801-goog

2020-03-13 18:06:19

by Harry Cutts

Subject: Re: [PATCH v3] Input: Allocate keycode for "Selective Screenshot" key

On Fri, 13 Mar 2020 at 11:03, Rajat Jain <[email protected]> wrote:
>
> New chromeos keyboards have a "snip" key that is basically a selective
> screenshot (allows a user to select an area of screen to be copied).
> Allocate a keycode for it.
>
> Signed-off-by: Rajat Jain <[email protected]>

Reviewed-by: Harry Cutts <[email protected]>

Harry Cutts
Chrome OS Touch/Input team

> ---
> v3: Rename KEY_SNIP to KEY_SELECTIVE_SNAPSHOT
> V2: Drop patch [1/2] and instead rebase this on top of Linus' tree.
>
> include/uapi/linux/input-event-codes.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index 0f1db1cccc3fd..c4dbe2ee9c098 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -652,6 +652,8 @@
> /* Electronic privacy screen control */
> #define KEY_PRIVACY_SCREEN_TOGGLE 0x279
>
> +#define KEY_SELECTIVE_SCREENSHOT 0x280
> +
> /*
> * Some keyboards have keys which do not have a defined meaning, these keys
> * are intended to be programmed / bound to macros by the user. For most
> --
> 2.25.1.481.gfbce0eb801-goog
>

2020-03-18 03:57:24

by Dmitry Torokhov

Subject: Re: [PATCH v3] Input: Allocate keycode for "Selective Screenshot" key

On Fri, Mar 13, 2020 at 11:03:33AM -0700, Rajat Jain wrote:
> New chromeos keyboards have a "snip" key that is basically a selective
> screenshot (allows a user to select an area of screen to be copied).
> Allocate a keycode for it.
>
> Signed-off-by: Rajat Jain <[email protected]>

Applied, thank you.

> ---
> v3: Rename KEY_SNIP to KEY_SELECTIVE_SNAPSHOT
> V2: Drop patch [1/2] and instead rebase this on top of Linus' tree.
>
> include/uapi/linux/input-event-codes.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index 0f1db1cccc3fd..c4dbe2ee9c098 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -652,6 +652,8 @@
> /* Electronic privacy screen control */
> #define KEY_PRIVACY_SCREEN_TOGGLE 0x279
>
> +#define KEY_SELECTIVE_SCREENSHOT 0x280
> +
> /*
> * Some keyboards have keys which do not have a defined meaning, these keys
> * are intended to be programmed / bound to macros by the user. For most
> --
> 2.25.1.481.gfbce0eb801-goog
>

--
Dmitry

2020-03-18 04:13:27

by Rajat Jain

Subject: Re: [PATCH v3] Input: Allocate keycode for "Selective Screenshot" key

On Tue, Mar 17, 2020 at 8:56 PM Dmitry Torokhov
<[email protected]> wrote:
>
> On Fri, Mar 13, 2020 at 11:03:33AM -0700, Rajat Jain wrote:
> > New chromeos keyboards have a "snip" key that is basically a selective
> > screenshot (allows a user to select an area of screen to be copied).
> > Allocate a keycode for it.
> >
> > Signed-off-by: Rajat Jain <[email protected]>
>
> Applied, thank you.

I just noticed that I had by mistake used KEY_SELECTIVE_SNAPSHOT
instead of intended KEY_SELECTIVE_SCREENSHOT in the commit message. My
apologies. Can you please fix the commit message if not already
pushed. Otherwise I can send a follow up patch if you'd like.

Thanks & Best Regards,

Rajat

>
> > ---
> > v3: Rename KEY_SNIP to KEY_SELECTIVE_SNAPSHOT
> > V2: Drop patch [1/2] and instead rebase this on top of Linus' tree.
> >
> > include/uapi/linux/input-event-codes.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> > index 0f1db1cccc3fd..c4dbe2ee9c098 100644
> > --- a/include/uapi/linux/input-event-codes.h
> > +++ b/include/uapi/linux/input-event-codes.h
> > @@ -652,6 +652,8 @@
> > /* Electronic privacy screen control */
> > #define KEY_PRIVACY_SCREEN_TOGGLE 0x279
> >
> > +#define KEY_SELECTIVE_SCREENSHOT 0x280
> > +
> > /*
> > * Some keyboards have keys which do not have a defined meaning, these keys
> > * are intended to be programmed / bound to macros by the user. For most
> > --
> > 2.25.1.481.gfbce0eb801-goog
> >
>
> --
> Dmitry

2020-03-18 04:16:08

by Rajat Jain

Subject: Re: [PATCH v3] Input: Allocate keycode for "Selective Screenshot" key

On Tue, Mar 17, 2020 at 9:12 PM Rajat Jain <[email protected]> wrote:
>
> On Tue, Mar 17, 2020 at 8:56 PM Dmitry Torokhov
> <[email protected]> wrote:
> >
> > On Fri, Mar 13, 2020 at 11:03:33AM -0700, Rajat Jain wrote:
> > > New chromeos keyboards have a "snip" key that is basically a selective
> > > screenshot (allows a user to select an area of screen to be copied).
> > > Allocate a keycode for it.
> > >
> > > Signed-off-by: Rajat Jain <[email protected]>
> >
> > Applied, thank you.
>
> I just noticed that I had by mistake used KEY_SELECTIVE_SNAPSHOT
> instead of intended KEY_SELECTIVE_SCREENSHOT in the commit message. My
> apologies. Can you please fix the commit message if not already
> pushed. Otherwise I can send a follow up patch if you'd like.

Arghhh..... please disregard. I was looking at the wrong place. The
patch was correct. No need to do anything.

Thanks! :-)

Best Regards,

Rajat


>
> Thanks & Best Regards,
>
> Rajat
>
> >
> > > ---
> > > v3: Rename KEY_SNIP to KEY_SELECTIVE_SNAPSHOT
> > > V2: Drop patch [1/2] and instead rebase this on top of Linus' tree.
> > >
> > > include/uapi/linux/input-event-codes.h | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> > > index 0f1db1cccc3fd..c4dbe2ee9c098 100644
> > > --- a/include/uapi/linux/input-event-codes.h
> > > +++ b/include/uapi/linux/input-event-codes.h
> > > @@ -652,6 +652,8 @@
> > > /* Electronic privacy screen control */
> > > #define KEY_PRIVACY_SCREEN_TOGGLE 0x279
> > >
> > > +#define KEY_SELECTIVE_SCREENSHOT 0x280
> > > +
> > > /*
> > > * Some keyboards have keys which do not have a defined meaning, these keys
> > > * are intended to be programmed / bound to macros by the user. For most
> > > --
> > > 2.25.1.481.gfbce0eb801-goog
> > >
> >
> > --
> > Dmitry