2014-06-02 03:52:12

by Chase Southwood

[permalink] [raw]
Subject: Re: [PATCH 6/6] staging: comedi: addi_apci_1564: cleanup v_ADDI_Interrupt()

On Fri, May 30, 2014 at 12:26 PM, Hartley Sweeten
<[email protected]> wrote:
> On Thursday, May 29, 2014 9:44 PM, Chase Southwood wrote:
>> Move the function apci1564_interrupt() from hwdrv_apci1564.c to
>> addi_apci_1564.c. On moving, for now just strip out all of the
>> code for interrupts that the driver does not yet support at this
>> time.
>>
>> Rename the variable ui_InterruptStatus_1564 to ctrl, and change the return
>> from IRQ_RETVAL(1) to IRQ_HANDLED.
>>
>> We also check the device is asserting the shared interrupt line and check
>> that interrupts have been enabled.
>>
>> Signed-off-by: Chase Southwood <[email protected]>
>> Cc: Ian Abbott <[email protected]>
>> Cc: H Hartley Sweeten <[email protected]>
>> ---

Hartley,

Excellent...I will draft up a new version of this set based on all of
your comments, but I will hold off on sending until I see if Ian has
anything further to offer. Things are certainly looking better
already though.

Thanks,
Chase