2024-02-02 13:37:07

by Wasim Nazir

Subject: [PATCH 1/3] dt-bindings: arm: qcom: Document rb5gen2-hdk board

Document board bindings for Rb5 gen2 hardware development kit.
Rb5gen2-HDK is using Rb5 gen2 SOM which is based on QCS8550 SoC.
RB5gen2-HDK is development kit used for IOT solutions.

Signed-off-by: Wasim Nazir <[email protected]>

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 9cee874a8eae..ce5b5dfe0e46 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -104,6 +104,7 @@ description: |
qcp
qrd
rb2
+ rb5gen2-hdk
ride
sbc
x100
@@ -915,6 +916,14 @@ properties:
- const: qcom,qcm8550
- const: qcom,sm8550

+ - items:
+ - enum:
+ - qcom,qcs8550-rb5gen2-hdk
+ - const: qcom,qcs8550-rb5gen2
+ - const: qcom,qcs8550
+ - const: qcom,qcm8550
+ - const: qcom,sm8550
+
- items:
- enum:
- qcom,sa8155p-adp
--
2.43.0

2024-02-02 14:34:41

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/3] dt-bindings: arm: qcom: Document rb5gen2-hdk board

On 02/02/2024 14:36, Wasim Nazir wrote:
> Document board bindings for Rb5 gen2 hardware development kit.
> Rb5gen2-HDK is using Rb5 gen2 SOM which is based on QCS8550 SoC.
> RB5gen2-HDK is development kit used for IOT solutions.
>
> Signed-off-by: Wasim Nazir <[email protected]>
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 9cee874a8eae..ce5b5dfe0e46 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -104,6 +104,7 @@ description: |
> qcp
> qrd
> rb2
> + rb5gen2-hdk

I think we decided to stop growing this, especially that "rb5gen2-hdk"
does not look generic type of a board.

> --
> 2.43.0
>

Best regards,
Krzysztof

2024-02-02 14:51:52

by Dmitry Baryshkov

Subject: Re: [PATCH 1/3] dt-bindings: arm: qcom: Document rb5gen2-hdk board

On Fri, 2 Feb 2024 at 15:37, Wasim Nazir <[email protected]> wrote:
>
> Document board bindings for Rb5 gen2 hardware development kit.
> Rb5gen2-HDK is using Rb5 gen2 SOM which is based on QCS8550 SoC.
> RB5gen2-HDK is development kit used for IOT solutions.

What is the actual marketing name for the SoM and the carrier board?
The RB5gen2-HDK doesn't follow the previous example of the RB* boards
and doesn't sound in tune with the RB3gen2 submission.
Could you please sync up internally and come up with two similar names
for the platforms with similar purpose?

>
> Signed-off-by: Wasim Nazir <[email protected]>
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 9cee874a8eae..ce5b5dfe0e46 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -104,6 +104,7 @@ description: |
> qcp
> qrd
> rb2
> + rb5gen2-hdk
> ride
> sbc
> x100
> @@ -915,6 +916,14 @@ properties:
> - const: qcom,qcm8550
> - const: qcom,sm8550
>
> + - items:
> + - enum:
> + - qcom,qcs8550-rb5gen2-hdk
> + - const: qcom,qcs8550-rb5gen2
> + - const: qcom,qcs8550
> + - const: qcom,qcm8550
> + - const: qcom,sm8550
> +
> - items:
> - enum:
> - qcom,sa8155p-adp
> --
> 2.43.0
>
>


--
With best wishes
Dmitry

2024-02-27 06:47:46

by Wasim Nazir

Subject: Re: [PATCH 1/3] dt-bindings: arm: qcom: Document rb5gen2-hdk board

On 2/2/2024 8:04 PM, Krzysztof Kozlowski wrote:
> On 02/02/2024 14:36, Wasim Nazir wrote:
>> Document board bindings for Rb5 gen2 hardware development kit.
>> Rb5gen2-HDK is using Rb5 gen2 SOM which is based on QCS8550 SoC.
>> RB5gen2-HDK is development kit used for IOT solutions.
>>
>> Signed-off-by: Wasim Nazir <[email protected]>
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 9cee874a8eae..ce5b5dfe0e46 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -104,6 +104,7 @@ description: |
>> qcp
>> qrd
>> rb2
>> + rb5gen2-hdk
>
> I think we decided to stop growing this, especially that "rb5gen2-hdk"
> does not look generic type of a board.
>
Will remove this in next patch version.

>> --
>> 2.43.0
>>
>
> Best regards,
> Krzysztof
>

Thanks & regards,
Wasim

2024-02-27 06:54:17

by Wasim Nazir

Subject: Re: [PATCH 1/3] dt-bindings: arm: qcom: Document rb5gen2-hdk board

On 2/2/2024 8:21 PM, Dmitry Baryshkov wrote:
> On Fri, 2 Feb 2024 at 15:37, Wasim Nazir <[email protected]> wrote:
>>
>> Document board bindings for Rb5 gen2 hardware development kit.
>> Rb5gen2-HDK is using Rb5 gen2 SOM which is based on QCS8550 SoC.
>> RB5gen2-HDK is development kit used for IOT solutions.
>
> What is the actual marketing name for the SoM and the carrier board?
> The RB5gen2-HDK doesn't follow the previous example of the RB* boards
> and doesn't sound in tune with the RB3gen2 submission.
> Could you please sync up internally and come up with two similar names
> for the platforms with similar purpose?
>
Discussed internally and we concluded on these official names, will
update accordingly in next patch.

SOM: qcs8550-rb5gen2-som.dtsi
Board: qcs8550-rb5gen2.dts

>>
>> Signed-off-by: Wasim Nazir <[email protected]>
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 9cee874a8eae..ce5b5dfe0e46 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -104,6 +104,7 @@ description: |
>> qcp
>> qrd
>> rb2
>> + rb5gen2-hdk
>> ride
>> sbc
>> x100
>> @@ -915,6 +916,14 @@ properties:
>> - const: qcom,qcm8550
>> - const: qcom,sm8550
>>
>> + - items:
>> + - enum:
>> + - qcom,qcs8550-rb5gen2-hdk
>> + - const: qcom,qcs8550-rb5gen2
>> + - const: qcom,qcs8550
>> + - const: qcom,qcm8550
>> + - const: qcom,sm8550
>> +
>> - items:
>> - enum:
>> - qcom,sa8155p-adp
>> --
>> 2.43.0
>>
>>
>
>

Thanks & Regards,
Wasim