2020-10-05 11:53:37

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: Fixes tag needs some work in the battery tree

---

Hi all,

In commit

f9d293364b45 ("power: supply: sbs-battery: keep error code when get_property() fails")

Fixes tag

Fixes: c4f382930145 (power: supply: sbs-battery: don't assume i2c errors as battery disconnect)

has these problem(s):

- Target SHA1 does not exist

Maybe you meant

Fixes: 395a7251dc2b ("power: supply: sbs-battery: don't assume i2c errors as battery disconnect")

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2020-10-06 04:00:09

by Ikjoon Jang

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the battery tree

---

On Mon, Oct 5, 2020 at 7:50 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> In commit
>
> f9d293364b45 ("power: supply: sbs-battery: keep error code when get_property() fails")
>
> Fixes tag
>
> Fixes: c4f382930145 (power: supply: sbs-battery: don't assume i2c errors as battery disconnect)
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 395a7251dc2b ("power: supply: sbs-battery: don't assume i2c errors as battery disconnect")
>

Yes, you're right. I guess I made a mistake here.
I'll send a v2 patch.

Thank you!

> --
> Cheers,
> Stephen Rothwell

2020-10-06 04:20:08

by Ikjoon Jang

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the battery tree

---

On Tue, Oct 6, 2020 at 11:57 AM Ikjoon Jang <[email protected]> wrote:
>
> On Mon, Oct 5, 2020 at 7:50 PM Stephen Rothwell <[email protected]> wrote:
> >
> > Hi all,
> >
> > In commit
> >
> > f9d293364b45 ("power: supply: sbs-battery: keep error code when get_property() fails")
> >
> > Fixes tag
> >
> > Fixes: c4f382930145 (power: supply: sbs-battery: don't assume i2c errors as battery disconnect)
> >
> > has these problem(s):
> >
> > - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: 395a7251dc2b ("power: supply: sbs-battery: don't assume i2c errors as battery disconnect")
> >
>
> Yes, you're right. I guess I made a mistake here.
> I'll send a v2 patch.

Oh I'm sorry, it's from linux-next!

I found d6e24aa0bf15 ("power: supply: sbs-battery: keep error code
when get_property() fails") on sre/for-next branch
with a valid Fixes tag:

power: supply: sbs-battery: keep error code when get_property() fails

Commit c4f382930145 (power: supply: sbs-battery: don't assume
i2c errors as battery disconnect) overwrites the original error code
returned from internal functions. On such a sporadic i2c error,
a user will get a wrong value without errors.

Fixes: 395a7251dc2b (power: supply: sbs-battery: don't assume i2c
errors as battery disconnect)

Signed-off-by: Ikjoon Jang <[email protected]>
Signed-off-by: Sebastian Reichel <[email protected]>

but there is still a wrong sha-1 hash in the commit message,
Sebastian, can you please amend the commit message before merge?


>
> Thank you!
>
> > --
> > Cheers,
> > Stephen Rothwell