LinuxLists.cc - linux-next: build warning after merge of the nand tree

2023-12-01 01:57:09

Subject: linux-next: build warning after merge of the nand tree

Hi all,

After merging the nand tree, today's linux-next build (htmldocs) produced
this warning:

include/linux/mtd/rawnand.h:1016: warning: Function parameter or member 'deassert_wp' not described in 'nand_operation'

Introduced by commit

e82a5a014dd5 ("mtd: rawnand: Add destructive operation")

--
Cheers,
Stephen Rothwell

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2023-12-01 05:04:45

by David Regan

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the nand tree

Hi Stephen,

from this post:
https://github.com/bbrezillon/linux/commit/e612e1f2c69a33ac5f2c91d13669f0f172d58717

Looks like this comment needs to be added:

* @deassert_wp: set to true when the operation requires the WP pin to be
* de-asserted (ERASE, PROG, ...)

What's the best way to go about doing this?

Thanks!

-Dave

On Thu, Nov 30, 2023 at 5:56 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the nand tree, today's linux-next build (htmldocs) produced
> this warning:
>
> include/linux/mtd/rawnand.h:1016: warning: Function parameter or member 'deassert_wp' not described in 'nand_operation'
>
> Introduced by commit
>
> e82a5a014dd5 ("mtd: rawnand: Add destructive operation")
>
> --
> Cheers,
> Stephen Rothwell

2023-12-01 11:55:20

by Miquel Raynal

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the nand tree

Hi David,

[email protected] wrote on Thu, 30 Nov 2023 21:03:00 -0800:

> Hi Stephen,
>
> from this post:
> https://github.com/bbrezillon/linux/commit/e612e1f2c69a33ac5f2c91d13669f0f172d58717
>
> Looks like this comment needs to be added:
>
> * @deassert_wp: set to true when the operation requires the WP pin to be
> * de-asserted (ERASE, PROG, ...)
>
>
> What's the best way to go about doing this?

Please send a normal patch and I will take care of this.

Thanks,
Miquèl