2023-05-06 09:39:30

by ye.xingchen

[permalink] [raw]
Subject: [PATCH] riscv: mm: use bitmap_zero() API

From: Ye Xingchen <[email protected]>

bitmap_zero() is faster than bitmap_clear(), so use bitmap_zero()
instead of bitmap_clear().

Signed-off-by: Ye Xingchen <[email protected]>
---
arch/riscv/mm/context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/mm/context.c b/arch/riscv/mm/context.c
index 12e22e7330e7..217fd4de6134 100644
--- a/arch/riscv/mm/context.c
+++ b/arch/riscv/mm/context.c
@@ -67,7 +67,7 @@ static void __flush_context(void)
lockdep_assert_held(&context_lock);

/* Update the list of reserved ASIDs and the ASID bitmap. */
- bitmap_clear(context_asid_map, 0, num_asids);
+ bitmap_zero(context_asid_map, num_asids);

/* Mark already active ASIDs as used */
for_each_possible_cpu(i) {
--
2.25.1


2023-05-07 15:44:13

by Anup Patel

[permalink] [raw]
Subject: Re: [PATCH] riscv: mm: use bitmap_zero() API

On Sat, May 6, 2023 at 2:42 PM <[email protected]> wrote:
>
> From: Ye Xingchen <[email protected]>
>
> bitmap_zero() is faster than bitmap_clear(), so use bitmap_zero()
> instead of bitmap_clear().
>
> Signed-off-by: Ye Xingchen <[email protected]>

Looks good to me.

Reviewed-by: Anup Patel <[email protected]>

Regards,
Anup

> ---
> arch/riscv/mm/context.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/mm/context.c b/arch/riscv/mm/context.c
> index 12e22e7330e7..217fd4de6134 100644
> --- a/arch/riscv/mm/context.c
> +++ b/arch/riscv/mm/context.c
> @@ -67,7 +67,7 @@ static void __flush_context(void)
> lockdep_assert_held(&context_lock);
>
> /* Update the list of reserved ASIDs and the ASID bitmap. */
> - bitmap_clear(context_asid_map, 0, num_asids);
> + bitmap_zero(context_asid_map, num_asids);
>
> /* Mark already active ASIDs as used */
> for_each_possible_cpu(i) {
> --
> 2.25.1

Subject: Re: [PATCH] riscv: mm: use bitmap_zero() API

Hello:

This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <[email protected]>:

On Sat, 6 May 2023 17:11:41 +0800 (CST) you wrote:
> From: Ye Xingchen <[email protected]>
>
> bitmap_zero() is faster than bitmap_clear(), so use bitmap_zero()
> instead of bitmap_clear().
>
> Signed-off-by: Ye Xingchen <[email protected]>
>
> [...]

Here is the summary with links:
- riscv: mm: use bitmap_zero() API
https://git.kernel.org/riscv/c/88ba8c83bead

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html