2023-11-16 10:54:51

by Joshua Yeong

Subject: [PATCH v3 1/1] clocksource/timer-riscv: Add riscv_clock_shutdown callback

Add clocksource detach/shutdown callback to disable RISC-V timer interrupt when
switching out riscv timer as clock source

Signed-off-by: Joshua Yeong <[email protected]>
---
drivers/clocksource/timer-riscv.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/clocksource/timer-riscv.c b/drivers/clocksource/timer-riscv.c
index 57857c0dfba9..e66dcbd66566 100644
--- a/drivers/clocksource/timer-riscv.c
+++ b/drivers/clocksource/timer-riscv.c
@@ -61,12 +61,19 @@ static int riscv_clock_next_event(unsigned long delta,
return 0;
}

+static int riscv_clock_shutdown(struct clock_event_device *evt)
+{
+ riscv_clock_event_stop();
+ return 0;
+}
+
static unsigned int riscv_clock_event_irq;
static DEFINE_PER_CPU(struct clock_event_device, riscv_clock_event) = {
.name = "riscv_timer_clockevent",
.features = CLOCK_EVT_FEAT_ONESHOT,
.rating = 100,
.set_next_event = riscv_clock_next_event,
+ .set_state_shutdown = riscv_clock_shutdown,
};

/*
--
2.25.1

2023-11-16 11:52:11

by Anup Patel

Subject: Re: [PATCH v3 1/1] clocksource/timer-riscv: Add riscv_clock_shutdown callback

On Thu, Nov 16, 2023 at 4:24 PM Joshua Yeong
<[email protected]> wrote:
>
> Add clocksource detach/shutdown callback to disable RISC-V timer interrupt when
> switching out riscv timer as clock source
>
> Signed-off-by: Joshua Yeong <[email protected]>

Please include Rb tags obtained in previous revisions.

Reviewed-by: Anup Patel <[email protected]>

Regards,
Anup

> ---
> drivers/clocksource/timer-riscv.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/clocksource/timer-riscv.c b/drivers/clocksource/timer-riscv.c
> index 57857c0dfba9..e66dcbd66566 100644
> --- a/drivers/clocksource/timer-riscv.c
> +++ b/drivers/clocksource/timer-riscv.c
> @@ -61,12 +61,19 @@ static int riscv_clock_next_event(unsigned long delta,
> return 0;
> }
>
> +static int riscv_clock_shutdown(struct clock_event_device *evt)
> +{
> + riscv_clock_event_stop();
> + return 0;
> +}
> +
> static unsigned int riscv_clock_event_irq;
> static DEFINE_PER_CPU(struct clock_event_device, riscv_clock_event) = {
> .name = "riscv_timer_clockevent",
> .features = CLOCK_EVT_FEAT_ONESHOT,
> .rating = 100,
> .set_next_event = riscv_clock_next_event,
> + .set_state_shutdown = riscv_clock_shutdown,
> };
>
> /*
> --
> 2.25.1
>

2023-12-04 17:57:04

by Daniel Lezcano

Subject: Re: [PATCH v3 1/1] clocksource/timer-riscv: Add riscv_clock_shutdown callback

On 16/11/2023 11:53, Joshua Yeong wrote:
> Add clocksource detach/shutdown callback to disable RISC-V timer interrupt when
> switching out riscv timer as clock source
>
> Signed-off-by: Joshua Yeong <[email protected]>
> ---

Applied, thanks

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2024-01-18 19:24:34

by tip-bot2 for Jacob Pan

Subject: [tip: timers/core] clocksource/timer-riscv: Add riscv_clock_shutdown callback

The following commit has been merged into the timers/core branch of tip:

Commit-ID: 6a902b118e7f30dbf0e6248f7b0f97e12c0939c3
Gitweb: https://git.kernel.org/tip/6a902b118e7f30dbf0e6248f7b0f97e12c0939c3
Author: Joshua Yeong <[email protected]>
AuthorDate: Thu, 16 Nov 2023 18:53:12 +08:00
Committer: Daniel Lezcano <[email protected]>
CommitterDate: Wed, 27 Dec 2023 15:37:11 +01:00

clocksource/timer-riscv: Add riscv_clock_shutdown callback

Add clocksource detach/shutdown callback to disable RISC-V timer interrupt when
switching out riscv timer as clock source

Signed-off-by: Joshua Yeong <[email protected]>
Reviewed-by: Anup Patel <[email protected]>
Signed-off-by: Daniel Lezcano <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/clocksource/timer-riscv.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/clocksource/timer-riscv.c b/drivers/clocksource/timer-riscv.c
index 57857c0..e66dcbd 100644
--- a/drivers/clocksource/timer-riscv.c
+++ b/drivers/clocksource/timer-riscv.c
@@ -61,12 +61,19 @@ static int riscv_clock_next_event(unsigned long delta,
return 0;
}

+static int riscv_clock_shutdown(struct clock_event_device *evt)
+{
+ riscv_clock_event_stop();
+ return 0;
+}
+
static unsigned int riscv_clock_event_irq;
static DEFINE_PER_CPU(struct clock_event_device, riscv_clock_event) = {
.name = "riscv_timer_clockevent",
.features = CLOCK_EVT_FEAT_ONESHOT,
.rating = 100,
.set_next_event = riscv_clock_next_event,
+ .set_state_shutdown = riscv_clock_shutdown,
};

/*