2022-06-02 19:25:40

by Huacai Chen

Subject: [PATCH V14 01/24] irqchip: Adjust Kconfig for Loongson

HTVEC will be shared by both MIPS-based and LoongArch-based Loongson
processors (not only Loongson-3), so we adjust its description. HTPIC is
only used by MIPS-based Loongson, so we add a MIPS dependency.

Cc: Marc Zyngier <[email protected]>
Reviewed-by: WANG Xuerui <[email protected]>
Reviewed-by: Jiaxun Yang <[email protected]>
Signed-off-by: Huacai Chen <[email protected]>
---
drivers/irqchip/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 44fb8843e80e..1cb3967fe798 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -557,7 +557,7 @@ config LOONGSON_LIOINTC

config LOONGSON_HTPIC
bool "Loongson3 HyperTransport PIC Controller"
- depends on MACH_LOONGSON64
+ depends on (MACH_LOONGSON64 && MIPS)
default y
select IRQ_DOMAIN
select GENERIC_IRQ_CHIP
@@ -565,12 +565,12 @@ config LOONGSON_HTPIC
Support for the Loongson-3 HyperTransport PIC Controller.

config LOONGSON_HTVEC
- bool "Loongson3 HyperTransport Interrupt Vector Controller"
+ bool "Loongson HyperTransport Interrupt Vector Controller"
depends on MACH_LOONGSON64
default MACH_LOONGSON64
select IRQ_DOMAIN_HIERARCHY
help
- Support for the Loongson3 HyperTransport Interrupt Vector Controller.
+ Support for the Loongson HyperTransport Interrupt Vector Controller.

config LOONGSON_PCH_PIC
bool "Loongson PCH PIC Controller"
--
2.27.0

2022-06-03 16:18:02

by Randy Dunlap

Subject: Re: [PATCH V14 01/24] irqchip: Adjust Kconfig for Loongson

Hi,

On 6/2/22 04:51, Huacai Chen wrote:
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 44fb8843e80e..1cb3967fe798 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -557,7 +557,7 @@ config LOONGSON_LIOINTC
>
> config LOONGSON_HTPIC
> bool "Loongson3 HyperTransport PIC Controller"
> - depends on MACH_LOONGSON64
> + depends on (MACH_LOONGSON64 && MIPS)

If you ever have another patch version, please drop the unnecessary left and
right parentheses above.

depends on MACH_LOONGSON64 && MIPS

> default y
> select IRQ_DOMAIN
> select GENERIC_IRQ_CHIP

thanks.
--
~Randy

2022-06-03 18:50:45

by Huacai Chen

Subject: Re: [PATCH V14 01/24] irqchip: Adjust Kconfig for Loongson

Hi, Randy,

On Fri, Jun 3, 2022 at 12:34 AM Randy Dunlap <[email protected]> wrote:
>
> Hi,
>
> On 6/2/22 04:51, Huacai Chen wrote:
> > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> > index 44fb8843e80e..1cb3967fe798 100644
> > --- a/drivers/irqchip/Kconfig
> > +++ b/drivers/irqchip/Kconfig
> > @@ -557,7 +557,7 @@ config LOONGSON_LIOINTC
> >
> > config LOONGSON_HTPIC
> > bool "Loongson3 HyperTransport PIC Controller"
> > - depends on MACH_LOONGSON64
> > + depends on (MACH_LOONGSON64 && MIPS)
>
> If you ever have another patch version, please drop the unnecessary left and
> right parentheses above.
OK, thanks, I will do that.

Huacai
>
> depends on MACH_LOONGSON64 && MIPS
>
> > default y
> > select IRQ_DOMAIN
> > select GENERIC_IRQ_CHIP
>
> thanks.
> --
> ~Randy