2024-04-02 10:41:51

by Wentao Guan

Subject: [PATCH] LoongArch: KVM: Remove useless MODULE macro for MODULE_DEVICE_TABLE

MODULE_DEVICE_TABLE use ifdef MODULE macro in module.h,
just clean it up.

Suggested-by: Yuli Wang <[email protected]>
Signed-off-by: Wentao Guan <[email protected]>
---
arch/loongarch/kvm/main.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/loongarch/kvm/main.c b/arch/loongarch/kvm/main.c
index 86a2f2d0cb27..7f2bd9a0814c 100644
--- a/arch/loongarch/kvm/main.c
+++ b/arch/loongarch/kvm/main.c
@@ -410,10 +410,8 @@ static void kvm_loongarch_exit(void)
module_init(kvm_loongarch_init);
module_exit(kvm_loongarch_exit);

-#ifdef MODULE
static const struct cpu_feature kvm_feature[] = {
{ .feature = cpu_feature(LOONGARCH_LVZ) },
{},
};
MODULE_DEVICE_TABLE(cpu, kvm_feature);
-#endif
--
2.20.1

2024-04-02 10:43:21

by Xi Ruoyao

Subject: Re: [PATCH] LoongArch: KVM: Remove useless MODULE macro for MODULE_DEVICE_TABLE

This should be Cc'ed to the KVM list.

On Tue, 2024-04-02 at 18:39 +0800, Wentao Guan wrote:
> MODULE_DEVICE_TABLE use ifdef MODULE macro in module.h,
> just clean it up.
>
> Suggested-by: Yuli Wang <[email protected]>
> Signed-off-by: Wentao Guan <[email protected]>
> ---
>  arch/loongarch/kvm/main.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/loongarch/kvm/main.c b/arch/loongarch/kvm/main.c
> index 86a2f2d0cb27..7f2bd9a0814c 100644
> --- a/arch/loongarch/kvm/main.c
> +++ b/arch/loongarch/kvm/main.c
> @@ -410,10 +410,8 @@ static void kvm_loongarch_exit(void)
>  module_init(kvm_loongarch_init);
>  module_exit(kvm_loongarch_exit);
>  
> -#ifdef MODULE
>  static const struct cpu_feature kvm_feature[] = {
>   { .feature = cpu_feature(LOONGARCH_LVZ) },
>   {},
>  };
>  MODULE_DEVICE_TABLE(cpu, kvm_feature);
> -#endif

--
Xi Ruoyao <[email protected]>
School of Aerospace Science and Technology, Xidian University

2024-04-02 10:46:42

by Wentao Guan

Subject: Re: [PATCH] LoongArch: KVM: Remove useless MODULE macro for MODULE_DEVICE_TABLE

OK, it will resend in PATCH V2.
I have a mistake to not add "__maybe_unused" in cpu_feature structure.

2024-04-02 11:40:00

by maobibo

Subject: Re: [PATCH] LoongArch: KVM: Remove useless MODULE macro for MODULE_DEVICE_TABLE

On 2024/4/2 下午6:39, Wentao Guan wrote:
> MODULE_DEVICE_TABLE use ifdef MODULE macro in module.h,
> just clean it up.
>
> Suggested-by: Yuli Wang <[email protected]>
> Signed-off-by: Wentao Guan <[email protected]>
> ---
> arch/loongarch/kvm/main.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/loongarch/kvm/main.c b/arch/loongarch/kvm/main.c
> index 86a2f2d0cb27..7f2bd9a0814c 100644
> --- a/arch/loongarch/kvm/main.c
> +++ b/arch/loongarch/kvm/main.c
> @@ -410,10 +410,8 @@ static void kvm_loongarch_exit(void)
> module_init(kvm_loongarch_init);
> module_exit(kvm_loongarch_exit);
>
> -#ifdef MODULE
> static const struct cpu_feature kvm_feature[] = {
> { .feature = cpu_feature(LOONGARCH_LVZ) },
> {},
> };
Wentao,

Thanks for your patch, there is static variable kvm_feature
which is embraced by macro MODULE also :-), besides MODULE_DEVICE_TABLE.

Regards
Bibo Mao
> MODULE_DEVICE_TABLE(cpu, kvm_feature);
> -#endif
>

2024-04-02 13:24:11

by maobibo

Subject: Re: [PATCH] LoongArch: KVM: Remove useless MODULE macro for MODULE_DEVICE_TABLE

On 2024/4/2 下午8:47, Wentao Guan wrote:
> Hello,Bibo,
>
> I change this that we see other guys use "MODULE_DEVICE_TABLE(cpu,..."
> without use that MODULE macro,and mark cpu_feature struct "__maybe_unused",
> do the same way to avoid unused variable compiler warning  :).

yeap, it looks good to me with __maybe_unused added.

Regards
Bibo Mao
>
> BRs
> Wentao Guan
>

2024-04-02 14:42:51

by Huacai Chen

Subject: Re: [PATCH] LoongArch: KVM: Remove useless MODULE macro for MODULE_DEVICE_TABLE

On Tue, Apr 2, 2024 at 6:46 PM Wentao Guan <[email protected]> wrote:
>
> OK, it will resend in PATCH V2.
> I have a mistake to not add "__maybe_unused" in cpu_feature structure.

__maybe_unused is not encouraged unless there is no other solution, in
this case it is better to keep the old style, which is the same as
vmx.c and svm.c in x86.

Huacai