2022-08-04 03:17:19

by Huacai Chen

Subject: [PATCH] irqchip/loongson-eiointc: Fix a build warning

Make acpi_get_vec_parent() be a static function, to avoid:
drivers/irqchip/irq-loongson-eiointc.c:289:20: warning: no previous prototype for 'acpi_get_vec_parent'

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Huacai Chen <[email protected]>
---
drivers/irqchip/irq-loongson-eiointc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c
index 317467857478..bffb7b3128e8 100644
--- a/drivers/irqchip/irq-loongson-eiointc.c
+++ b/drivers/irqchip/irq-loongson-eiointc.c
@@ -290,7 +290,7 @@ static void acpi_set_vec_parent(int node, struct irq_domain *parent, struct acpi
}
}

-struct irq_domain *acpi_get_vec_parent(int node, struct acpi_vector_group *vec_group)
+static struct irq_domain *acpi_get_vec_parent(int node, struct acpi_vector_group *vec_group)
{
int i;

--
2.31.1

2022-08-04 03:39:03

by Huacai Chen

Subject: Re: [PATCH] irqchip/loongson-eiointc: Fix a build warning

Hi, Marc,

Other build warnings reported by lkp due to the missing CONFIG_ACPI in
randconfig. So they will be fixed by adjusting arch/loongarch/Kconfig
and going through loongarch tree. Thanks.

Huacai

On Thu, Aug 4, 2022 at 10:54 AM Huacai Chen <[email protected]> wrote:
>
> Make acpi_get_vec_parent() be a static function, to avoid:
> drivers/irqchip/irq-loongson-eiointc.c:289:20: warning: no previous prototype for 'acpi_get_vec_parent'
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Huacai Chen <[email protected]>
> ---
> drivers/irqchip/irq-loongson-eiointc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c
> index 317467857478..bffb7b3128e8 100644
> --- a/drivers/irqchip/irq-loongson-eiointc.c
> +++ b/drivers/irqchip/irq-loongson-eiointc.c
> @@ -290,7 +290,7 @@ static void acpi_set_vec_parent(int node, struct irq_domain *parent, struct acpi
> }
> }
>
> -struct irq_domain *acpi_get_vec_parent(int node, struct acpi_vector_group *vec_group)
> +static struct irq_domain *acpi_get_vec_parent(int node, struct acpi_vector_group *vec_group)
> {
> int i;
>
> --
> 2.31.1
>

2022-08-04 13:58:09

by tip-bot2 for Jacob Pan

Subject: [irqchip: irq/irqchip-fixes] irqchip/loongson-eiointc: Fix a build warning

The following commit has been merged into the irq/irqchip-fixes branch of irqchip:

Commit-ID: 54cfa910b443b3d90b3e00bd96cdf563a285390b
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/54cfa910b443b3d90b3e00bd96cdf563a285390b
Author: Huacai Chen <[email protected]>
AuthorDate: Thu, 04 Aug 2022 10:54:57 +08:00
Committer: Marc Zyngier <[email protected]>
CommitterDate: Thu, 04 Aug 2022 10:04:57 +01:00

irqchip/loongson-eiointc: Fix a build warning

Make acpi_get_vec_parent() be a static function, to avoid:
drivers/irqchip/irq-loongson-eiointc.c:289:20: warning: no previous prototype for 'acpi_get_vec_parent'

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Huacai Chen <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/irqchip/irq-loongson-eiointc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c
index 3174678..bffb7b3 100644
--- a/drivers/irqchip/irq-loongson-eiointc.c
+++ b/drivers/irqchip/irq-loongson-eiointc.c
@@ -290,7 +290,7 @@ static void acpi_set_vec_parent(int node, struct irq_domain *parent, struct acpi
}
}

-struct irq_domain *acpi_get_vec_parent(int node, struct acpi_vector_group *vec_group)
+static struct irq_domain *acpi_get_vec_parent(int node, struct acpi_vector_group *vec_group)
{
int i;