2016-10-18 02:12:27

by Andrew Donnellan

[permalink] [raw]
Subject: Re: [PATCH 2/2] builddeb: allow building without headers/firmware packages

On 26/08/16 18:17, Andrew Donnellan wrote:
> Currently, the deb-pkg and bindeb-pkg targets create multiple packages for
> the kernel binaries, headers, userspace headers and firmware.
>
> For developers who generate Debian packages as part of their development
> workflows, it's often not necessary to generate all these packages.
>
> Allow the creation of the linux-headers, linux-libc-dev and linux-firmware
> packages to be disabled if the environment variables KDEB_NO_HEADERS,
> KDEB_NO_LIBC_HEADERS or KDEB_NO_FIRMWARE are non-empty.
>
> Signed-off-by: Andrew Donnellan <[email protected]>

Ping :)

> On top of d3e2773c4ede5c62d2a92dae20e3a09b1ca55b6e in kbuild#rc-fixes

This of course is now in mainline.

--
Andrew Donnellan OzLabs, ADL Canberra
[email protected] IBM Australia Limited


2016-11-25 12:24:34

by Riku Voipio

[permalink] [raw]
Subject: Re: [PATCH 2/2] builddeb: allow building without headers/firmware packages

On 18 October 2016 at 05:12, Andrew Donnellan
<[email protected]> wrote:
> On 26/08/16 18:17, Andrew Donnellan wrote:
>>
>> Currently, the deb-pkg and bindeb-pkg targets create multiple packages for
>> the kernel binaries, headers, userspace headers and firmware.
>>
>> For developers who generate Debian packages as part of their development
>> workflows, it's often not necessary to generate all these packages.
>>
>> Allow the creation of the linux-headers, linux-libc-dev and linux-firmware
>> packages to be disabled if the environment variables KDEB_NO_HEADERS,
>> KDEB_NO_LIBC_HEADERS or KDEB_NO_FIRMWARE are non-empty.
>>
>> Signed-off-by: Andrew Donnellan <[email protected]>

> Ping :)

I'm not a big fan of this patch. It adds some complexity as evident by
extra indent
level it adds. On practice developers would end up passing a long command line
with all KDEB_NO* variables.

Riku

>> On top of d3e2773c4ede5c62d2a92dae20e3a09b1ca55b6e in kbuild#rc-fixes
>
>
> This of course is now in mainline.
>
>
> --
> Andrew Donnellan OzLabs, ADL Canberra
> [email protected] IBM Australia Limited
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2016-11-29 00:07:03

by Andrew Donnellan

[permalink] [raw]
Subject: Re: [PATCH 2/2] builddeb: allow building without headers/firmware packages

On 25/11/16 23:24, Riku Voipio wrote:
> I'm not a big fan of this patch. It adds some complexity as evident by
> extra indent
> level it adds. On practice developers would end up passing a long command line
> with all KDEB_NO* variables.

That's fair! I think the approach in your new patch is probably better,
I'll review that.

--
Andrew Donnellan OzLabs, ADL Canberra
[email protected] IBM Australia Limited