2016-10-11 23:24:16

by Chase Metzger

Subject: [PATCH] drivers: staging: greybus: audio_manager_sysfs.c: Fixed CHECK for brace issue

Added braces to else and else if statements where checkpatch complained.

Signed-off-by: Chase Metzger <[email protected]>
---
drivers/staging/greybus/audio_manager_sysfs.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c
index d8bf859..376e17c 100644
--- a/drivers/staging/greybus/audio_manager_sysfs.c
+++ b/drivers/staging/greybus/audio_manager_sysfs.c
@@ -71,10 +71,11 @@ static ssize_t manager_sysfs_dump_store(
num = gb_audio_manager_dump_module(id);
if (num)
return num;
- } else if (!strncmp("all", buf, 3))
+ } else if (!strncmp("all", buf, 3)) {
gb_audio_manager_dump_all();
- else
+ } else {
return -EINVAL;
+ }

return count;
}
--
2.1.4

2016-10-12 06:00:39

by Vaibhav Agarwal

Subject: Re: [PATCH] drivers: staging: greybus: audio_manager_sysfs.c: Fixed CHECK for brace issue

On Wed, Oct 12, 2016 at 4:52 AM, Chase Metzger <[email protected]> wrote:
> Added braces to else and else if statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger <[email protected]>
> ---
> drivers/staging/greybus/audio_manager_sysfs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c
> index d8bf859..376e17c 100644
> --- a/drivers/staging/greybus/audio_manager_sysfs.c
> +++ b/drivers/staging/greybus/audio_manager_sysfs.c
> @@ -71,10 +71,11 @@ static ssize_t manager_sysfs_dump_store(
> num = gb_audio_manager_dump_module(id);
> if (num)
> return num;
> - } else if (!strncmp("all", buf, 3))
> + } else if (!strncmp("all", buf, 3)) {
> gb_audio_manager_dump_all();
> - else
> + } else {
> return -EINVAL;
> + }
>
> return count;
> }
> --
> 2.1.4
>
Reviewed-by: Vaibhav Agarwal <[email protected]>