2016-10-09 22:45:38

by Chase Metzger

Subject: [PATCH] drivers: staging: greybus: audio_codec.c: Fixed CHECKS for brace issues

Added braces to else statement where checkpatch complained.

Signed-off-by: Chase Metzger <[email protected]>
---
drivers/staging/greybus/audio_codec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
index 8a0744b..1bdf849 100644
--- a/drivers/staging/greybus/audio_codec.c
+++ b/drivers/staging/greybus/audio_codec.c
@@ -655,8 +655,10 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
ret = gb_audio_apbridgea_shutdown_rx(data->connection,
0);
params->state = GBAUDIO_CODEC_STOP;
- } else
+ } else {
ret = -EINVAL;
+ }
+
if (ret)
dev_err_ratelimited(dai->dev,
"%s:Error during %s %s stream:%d\n",
--
2.1.4

2016-10-10 12:12:00

by Vaibhav Agarwal

Subject: Re: [PATCH] drivers: staging: greybus: audio_codec.c: Fixed CHECKS for brace issues

On Mon, Oct 10, 2016 at 3:56 AM, Chase Metzger <[email protected]> wrote:
> Added braces to else statement where checkpatch complained.
>
> Signed-off-by: Chase Metzger <[email protected]>
> ---
> drivers/staging/greybus/audio_codec.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index 8a0744b..1bdf849 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -655,8 +655,10 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
> ret = gb_audio_apbridgea_shutdown_rx(data->connection,
> 0);
> params->state = GBAUDIO_CODEC_STOP;
> - } else
> + } else {
> ret = -EINVAL;
> + }
> +
> if (ret)
> dev_err_ratelimited(dai->dev,
> "%s:Error during %s %s stream:%d\n",
> --
> 2.1.4
>
Reviewed-by: Vaibhav Agarwal <[email protected]>