2023-09-21 17:40:01

by Andy Shevchenko

Subject: Re: [PATCH V2 1/4] gpio: sprd: In the sleep state, the eic debounce clk must be forced open

On Thu, Sep 21, 2023 at 05:00:24PM +0800, Wenhua Lin wrote:
> In the sleep state, Eic debounce has no clock and the clk of

Eic --> The eic

clk --> clock

> debounce needs to be forced open, so that eic can wake up normally.

> Fixes: 2788938b7946 ("gpio: eic-sprd: Make the irqchip immutable")
>
> Signed-off-by: Wenhua Lin <[email protected]>

The tag block mustn't have blank lines.

--
With Best Regards,
Andy Shevchenko

2024-01-02 08:35:18

by wenhua lin

Subject: Re: [PATCH V2 1/4] gpio: sprd: In the sleep state, the eic debounce clk must be forced open

On Thu, Sep 21, 2023 at 7:25 PM Andy Shevchenko <[email protected]> wrote:
>
> On Thu, Sep 21, 2023 at 05:00:24PM +0800, Wenhua Lin wrote:
> > In the sleep state, Eic debounce has no clock and the clk of
>
> Eic --> The eic
>
> clk --> clock
>
> > debounce needs to be forced open, so that eic can wake up normally.
>
> > Fixes: 2788938b7946 ("gpio: eic-sprd: Make the irqchip immutable")
> >
> > Signed-off-by: Wenhua Lin <[email protected]>
>
> The tag block mustn't have blank lines.
>

Thank you very much for your review.
I will fix this issue in patch v3.

> --
> With Best Regards,
> Andy Shevchenko
>
>