For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
Use the correct table.
The error was pointed out by this clang warning:
drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
[-Wunneeded-internal-declaration]
static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.")
Signed-off-by: Matthias Kaehlcke <[email protected]>
Reviewed-by: Manasi Navare <[email protected]>
---
Changes in v2:
- Added 'Fixes' tag
- Added Reviewed-by: Manasi Navare <[email protected]>
drivers/gpu/drm/i915/intel_ddi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index efb13582dc73..6fa02e6a7a9b 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -1873,7 +1873,7 @@ cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv,
if (dev_priv->vbt.edp.low_vswing) {
if (voltage == VOLTAGE_INFO_0_85V) {
*n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_85V);
- return cnl_ddi_translations_dp_0_85V;
+ return cnl_ddi_translations_edp_0_85V;
} else if (voltage == VOLTAGE_INFO_0_95V) {
*n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_95V);
return cnl_ddi_translations_edp_0_95V;
--
2.13.2.932.g7449e964c-goog
El Mon, Jul 17, 2017 at 12:58:54PM -0700 Matthias Kaehlcke ha dit:
> For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
> Use the correct table.
>
> The error was pointed out by this clang warning:
>
> drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
> 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
> [-Wunneeded-internal-declaration]
> static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
>
> Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.")
> Signed-off-by: Matthias Kaehlcke <[email protected]>
> Reviewed-by: Manasi Navare <[email protected]>
> ---
> Changes in v2:
> - Added 'Fixes' tag
> - Added Reviewed-by: Manasi Navare <[email protected]>
ping, it seems this patch went under the radar.
On Fri, Aug 11, 2017 at 11:32 AM, Matthias Kaehlcke <[email protected]> wrote:
> El Mon, Jul 17, 2017 at 12:58:54PM -0700 Matthias Kaehlcke ha dit:
>
>> For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
>> Use the correct table.
>>
>> The error was pointed out by this clang warning:
>>
>> drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
>> 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
>> [-Wunneeded-internal-declaration]
>> static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
>>
>> Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.")
>> Signed-off-by: Matthias Kaehlcke <[email protected]>
>> Reviewed-by: Manasi Navare <[email protected]>
>> ---
>> Changes in v2:
>> - Added 'Fixes' tag
>> - Added Reviewed-by: Manasi Navare <[email protected]>
>
> ping, it seems this patch went under the radar.
yes totally. sorry about that.
merged to dinq. Thanks for patch, review, and heads up
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br