2022-03-24 23:43:28

by Daniel Palmer

Subject: [PATCH 4/4] ARM: dts: mstar: Add second UART to base dtsi.

Add the second UART to the base dtsi.

Signed-off-by: Daniel Palmer <[email protected]>
---
arch/arm/boot/dts/mstar-v7.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/mstar-v7.dtsi b/arch/arm/boot/dts/mstar-v7.dtsi
index 8464a8f1b136..baf2422b9854 100644
--- a/arch/arm/boot/dts/mstar-v7.dtsi
+++ b/arch/arm/boot/dts/mstar-v7.dtsi
@@ -182,6 +182,14 @@ pm_uart: uart@221000 {
clock-frequency = <172000000>;
status = "disabled";
};
+
+ uart1: uart@221200 {
+ compatible = "mstar,msc313-uart", "snps,dw-apb-uart";
+ reg = <0x221200 0x100>;
+ reg-shift = <3>;
+ interrupts-extended = <&intc_irq GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ };
};

imi: sram@a0000000 {
--
2.35.1

2022-03-25 18:47:15

by Romain Perier

Subject: Re: [PATCH 4/4] ARM: dts: mstar: Add second UART to base dtsi.

Hi Daniel,


Le jeu. 24 mars 2022 à 13:44, Daniel Palmer <[email protected]> a écrit :
>
> Add the second UART to the base dtsi.
>
> Signed-off-by: Daniel Palmer <[email protected]>

More context in the long message would help, imho.
Otherwise:
Reviewed-by: Romain Perier <[email protected]>

2022-03-28 21:32:17

by Rob Herring

Subject: Re: [PATCH 4/4] ARM: dts: mstar: Add second UART to base dtsi.

On Thu, Mar 24, 2022 at 7:44 AM Daniel Palmer <[email protected]> wrote:
>
> Add the second UART to the base dtsi.
>
> Signed-off-by: Daniel Palmer <[email protected]>
> ---
> arch/arm/boot/dts/mstar-v7.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/mstar-v7.dtsi b/arch/arm/boot/dts/mstar-v7.dtsi
> index 8464a8f1b136..baf2422b9854 100644
> --- a/arch/arm/boot/dts/mstar-v7.dtsi
> +++ b/arch/arm/boot/dts/mstar-v7.dtsi
> @@ -182,6 +182,14 @@ pm_uart: uart@221000 {
> clock-frequency = <172000000>;
> status = "disabled";
> };
> +
> + uart1: uart@221200 {

serial@...

Please run schema checks on your DT as that should be a warning that I
don't have to tell you about.

Rob