2023-01-05 07:30:51

by Liming Wu

Subject: [PATCH] vhost-test: remove meaningless debug info

From: Liming Wu <[email protected]>

remove printk as it is meaningless.

Signed-off-by: Liming Wu <[email protected]>
---
drivers/vhost/test.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c
index bc8e7fb1e635..42c955a5b211 100644
--- a/drivers/vhost/test.c
+++ b/drivers/vhost/test.c
@@ -333,13 +333,10 @@ static long vhost_test_ioctl(struct file *f, unsigned int ioctl,
return -EFAULT;
return 0;
case VHOST_SET_FEATURES:
- printk(KERN_ERR "1\n");
if (copy_from_user(&features, featurep, sizeof features))
return -EFAULT;
- printk(KERN_ERR "2\n");
if (features & ~VHOST_FEATURES)
return -EOPNOTSUPP;
- printk(KERN_ERR "3\n");
return vhost_test_set_features(n, features);
case VHOST_RESET_OWNER:
return vhost_test_reset_owner(n);
--
2.25.1

2023-01-09 09:13:09

by Jason Wang

Subject: Re: [PATCH] vhost-test: remove meaningless debug info

On Thu, Jan 5, 2023 at 3:04 PM <[email protected]> wrote:
>
> From: Liming Wu <[email protected]>
>
> remove printk as it is meaningless.
>
> Signed-off-by: Liming Wu <[email protected]>

Acked-by: Jason Wang <[email protected]>

Thanks

> ---
> drivers/vhost/test.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c
> index bc8e7fb1e635..42c955a5b211 100644
> --- a/drivers/vhost/test.c
> +++ b/drivers/vhost/test.c
> @@ -333,13 +333,10 @@ static long vhost_test_ioctl(struct file *f, unsigned int ioctl,
> return -EFAULT;
> return 0;
> case VHOST_SET_FEATURES:
> - printk(KERN_ERR "1\n");
> if (copy_from_user(&features, featurep, sizeof features))
> return -EFAULT;
> - printk(KERN_ERR "2\n");
> if (features & ~VHOST_FEATURES)
> return -EOPNOTSUPP;
> - printk(KERN_ERR "3\n");
> return vhost_test_set_features(n, features);
> case VHOST_RESET_OWNER:
> return vhost_test_reset_owner(n);
> --
> 2.25.1
>