2019-04-10 08:48:57

by Baolin Wang

Subject: [PATCH] gpio: eic: sprd: Fix incorrect irq type setting for the sync EIC

When setting sync EIC as IRQ_TYPE_EDGE_BOTH type, we missed to set the
SPRD_EIC_SYNC_INTMODE register to 0, which means detecting edge signals.

Thus this patch fixes the issue.

Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support")
Cc: <[email protected]>
Signed-off-by: Baolin Wang <[email protected]>
---
drivers/gpio/gpio-eic-sprd.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
index f0223ce..7709226 100644
--- a/drivers/gpio/gpio-eic-sprd.c
+++ b/drivers/gpio/gpio-eic-sprd.c
@@ -414,6 +414,7 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
irq_set_handler_locked(data, handle_edge_irq);
break;
case IRQ_TYPE_EDGE_BOTH:
+ sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);
sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 1);
irq_set_handler_locked(data, handle_edge_irq);
break;
--
1.7.9.5

2019-04-11 13:41:29

by Linus Walleij

Subject: Re: [PATCH] gpio: eic: sprd: Fix incorrect irq type setting for the sync EIC

On Wed, Apr 10, 2019 at 9:48 AM Baolin Wang <[email protected]> wrote:

> When setting sync EIC as IRQ_TYPE_EDGE_BOTH type, we missed to set the
> SPRD_EIC_SYNC_INTMODE register to 0, which means detecting edge signals.
>
> Thus this patch fixes the issue.
>
> Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support")
> Cc: <[email protected]>
> Signed-off-by: Baolin Wang <[email protected]>

Patch applied for fixes.

Yours,
Linus Walleij