2023-10-09 09:24:01

by Uwe Kleine-König

Subject: [PATCH 02/20] pinctrl: single: Drop if block with always false condition

pcs_remove() is only called after pcs_probe() completed successfully. In
this case platform_set_drvdata() was called with a non-NULL argument and
so platform_get_drvdata() won't return NULL.

Simplify by removing the if block with the always false condition.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/pinctrl/pinctrl-single.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 461a7c02d4a3..f6c02c8b934d 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -1929,9 +1929,6 @@ static int pcs_remove(struct platform_device *pdev)
{
struct pcs_device *pcs = platform_get_drvdata(pdev);

- if (!pcs)
- return 0;
-
pcs_free_resources(pcs);

return 0;
--
2.40.1

2023-10-10 13:36:48

by Linus Walleij

Subject: Re: [PATCH 02/20] pinctrl: single: Drop if block with always false condition

On Mon, Oct 9, 2023 at 11:22 AM Uwe Kleine-König
<[email protected]> wrote:


> pcs_remove() is only called after pcs_probe() completed successfully. In
> this case platform_set_drvdata() was called with a non-NULL argument and
> so platform_get_drvdata() won't return NULL.
>
> Simplify by removing the if block with the always false condition.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Patch applied.

Yours,
Linus Walleij